postgres: alias insertion deadlock#1891
Draft
hdonnay wants to merge 2 commits into
Draft
Conversation
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
2 times, most recently
from
b8d0c0b to
da65def
Compare
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
from
da65def to
a43e074
Compare
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
from
a43e074 to
136e223
Compare
Adds a test that trips an Alias insertion deadlock. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I4f7f613f17e47c7cbcff82fbbb7674a06a6a6964
This fixes a transaction conflict where concurrent updaters could attempt to insert the same alias namespaces and cause the entire update to abort. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I4f7f613f17e47c7cbcff82fbbb7674a06a6a6964
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
from
136e223 to
5928a1b
Compare
9 tasks
Contributor
|
This appears to stop the deadlocks but causes the time to insert to increase considerably. Since we are inserting the aliases and namespaces outside of the transaction (so IIUC deadlocking is not an issue), would it be possible to collect all the aliases to be inserted using the dedupe maps that already exist and fire two bulk statements for the alias and the namespace? |
Member
Author
|
I'll take a look and try structuring it that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a transaction conflict where concurrent updaters could attempt to insert the same alias namespaces and cause the entire update to abort.
Hold: Needs a test.