claircore: add JSON marshaling for Alias type#1896
Merged
Conversation
jvdm
force-pushed
the
fix-alias-json
branch
2 times, most recently
from
524d0ad to
ff47f30
Compare
crozzy
reviewed
May 28, 2026
| } | ||
|
|
||
| type aliasJSON struct { | ||
| Space string `json:"Space"` |
Contributor
There was a problem hiding this comment.
Do we want the JSON keys to be capitalized? Seems like everything else is lower
| } | ||
| want := `{"Space":"","Name":""}` | ||
| if got := string(data); got != want { | ||
| t.Errorf("marshal: got %s, want %s", got, want) |
Contributor
There was a problem hiding this comment.
It seems like this isn't going to be totally symmetrical, i.e unmarshaling {"Space":"","Name":""} will return something different from Alias{} should. Do you think it's worth calling unmarshal and checking Valid() is false?
Contributor
|
blocked by #1891 |
jvdm
force-pushed
the
fix-alias-json
branch
2 times, most recently
from
c942d87 to
4629529
Compare
crozzy
approved these changes
Jun 23, 2026
hdonnay
approved these changes
Jun 23, 2026
hdonnay
left a comment
hdonnay
left a comment
Member
There was a problem hiding this comment.
If the outstanding deadlock isn't a concern, this should be fine.
I think we can live with the JSON marshaling continuing to be load bearing until a v2 or new updater subsystem.
9 tasks
unique.Handle[string] does not implement json.Marshaler, causing
Alias.Space to serialize as {} instead of the actual namespace value.
Add MarshalJSON and UnmarshalJSON to preserve Space values through JSON
round-trips.
Signed-off-by: J. Victor Martins <jvdm@sdf.org>
…bilities Signed-off-by: J. Victor Martins <jvdm@sdf.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unique.Handle[string]does not implementjson.Marshaler, causingAlias.Spaceto serialize as{}instead of the actual namespace value. This breaks vulnerability bundle serialization via jsonblob.Add
MarshalJSONandUnmarshalJSONto preserve Space values through JSON round-trips.