Add Russian localization - #248
Conversation
|
Thanks for the PR, I will review it ASAP. |
|
Thermo-nuclear code-quality review (automated) Verdict: Approve on code quality. Clean, pattern-faithful localization addition with good coverage. The wiring is exactly the established per-language pattern — one Nits (non-blocking):
Process flag for @Finesssee (not #248's fault): the PR body reports |
|
Thanks for the quick turnaround — both review items are addressed: the language-picker test now uses toBeGreaterThanOrEqual(7), and the two build-breaking TS errors are patched. Heads-up on overlap: main already carries the same two one-line TS fixes since #250 merged (byte-identical patches — MenuCardDetails localUsage type and the providerGridUtils fixture). A rebase onto current main turns your b106dbb hunks into no-ops and unblocks the hosted build step (main is green again: pnpm run build passes, plus the previously flaky cost-scan tests are now deterministic). Whenever you're ready: mark the PR ready-for-review + rebase onto main, and the hosted check should go green — happy to merge from there. The localization work itself is approved as-is. |
|
Merged 🎉 Thank you @serezha93 — first Russian UI for Win-CodexBar. 712-key catalog, aliases, bridge wiring and tests all in one clean PR, and you handled the review fixes quickly. Ships in the next release; native wording refinements are welcome as follow-up PRs. |
Summary
ru-RU) as a selectable UI languageWhy
Win-CodexBar currently offers six UI languages but no Russian option. This adds a native-language experience for Russian-speaking Windows users while preserving the existing English fallback behavior.
Validation
cargo test --manifest-path rust/Cargo.toml language --no-fail-fastcargo test --manifest-path rust/Cargo.toml locale::tests --no-fail-fastpnpm run check-locale— 712 keys match between Rust and TypeScriptpnpm test— 35 files / 211 tests passedBuild note
pnpm run tauri:build:debugcurrently stops on two pre-existing TypeScript errors inmain:ProviderUsageSnapshot.localUsageinMenuCardDetails.tsxand anullassignment inproviderGridUtils.test.ts. Neither file is changed by this PR.The catalog is complete; further native-speaker wording refinements are welcome during review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.