Skip to content

Add per-notification custom sounds (supersedes #249) - #251

Merged
Finesssee merged 7 commits into
mainfrom
agent/configure-notification-sound
Aug 4, 2026
Merged

Add per-notification custom sounds (supersedes #249)#251
Finesssee merged 7 commits into
mainfrom
agent/configure-notification-sound

Conversation

@Finesssee

@Finesssee Finesssee commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Supersedes

Summary

Per-notification-event custom WAV sounds: 7 embedded built-in sounds (48 kHz stereo PCM), per-event choose/preview/clear, Windows system-sound mapping preserved as default, serialized playback worker, toast audio silenced, save-time WAV validation (RIFF chunk walk), data-driven settings UI.

Review fixes on top of #249

  • Removed the dead sound_volume chain end-to-end (settings, bridge types, locale keys in all 7 catalogs, test mocks) — the field was never consumed by playback.
  • WAV validation happens at save only (play-time re-read dropped; failures surface as PlaybackFailed).
  • Replaced the as NotificationSoundTheme cast with a typed guard.
  • Includes the locale-catalog test update Russian requires (was red on main after Add Russian localization #248).

Validation

  • CUA proof on a fresh Windows debug build (proof-249/*.png): notifications surface shows 7 event rows + default sound set select; preview switches to "Playing…" and serializes (all 7 test buttons report IsEnabled=false during playback); restores after; theme switches Windows↔CodexBar both ways.
  • local-check.ps1 exit 0 on the branch; 857 rust + 328 tauri + 215 frontend tests; clippy -D warnings both crates; check-locale 732 keys.

View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

@Finesssee
Finesssee merged commit 3024240 into main Aug 4, 2026
3 checks passed
@Finesssee
Finesssee deleted the agent/configure-notification-sound branch August 4, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants