Skip to content

Stabilize iOS SQLite reservation timeout test #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

Stabilize iOS SQLite reservation timeout test #1449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe498c1
Initial plan
Copilot May 27, 2026
983e6de
test: stabilize sqlite reservation timeout test
Copilot May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/unittests/OfflineStorageTests_SQLite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,18 @@ TEST_F(OfflineStorageTests_SQLite, ReservedRecordsAreReleasedAfterTimeout)
ASSERT_THAT(consumer.records.size(), 1);
consumer.records.clear();

PAL::sleep(2000);
auto records = offlineStorage->GetRecords(true, EventLatency_Unspecified, 0);
ASSERT_THAT(records.size(), 2);
int64_t waitUntilMs = 0;
for (auto const& record : records)
{
waitUntilMs = std::max(waitUntilMs, record.reservedUntil);
}

while (PAL::getUtcSystemTimeMs() <= waitUntilMs + 250)
{
PAL::sleep(50);
}

// Both records are timed out
EXPECT_THAT(offlineStorage->GetAndReserveRecords(consumer, 1000), true);
Expand Down
Loading