Stabilize iOS SQLite reservation timeout test#1449
Open
Copilot wants to merge 2 commits into
Open
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for macOS build
Stabilize iOS SQLite reservation timeout test
May 27, 2026
lalitb
approved these changes
May 27, 2026
Contributor
|
This should be good to merge. I won't be merge this, as I triggered copilot to fix the issue, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing macOS/iOS Actions job was caused by a timing-sensitive unit test, not a build break.
OfflineStorageTests_SQLite.ReservedRecordsAreReleasedAfterTimeoutassumed fixed sleeps were enough for all leases to expire on the simulator, which was not reliably true.Root cause
PAL::sleep(2000)after reserving two records with different lease durations.reserved_untiltimestamp had actually elapsed.Change
reservedUntil, and waits until that deadline has passed with a small buffer.Effect