Skip to content

fix: correct lychee exit code handling #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Haleshot wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −7
Open

fix: correct lychee exit code handling #1960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e0800
fix: correct lychee exit code handling and prevent stale cache on sch…
Haleshot May 10, 2026
68cf585
fix: only create issue on scheduled runs to avoid token permission er…
Haleshot May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ name: Link Check

on:
pull_request:
branches: [main, v1]
branches: [main]
Copy link
Copy Markdown
Member

@georgeh0 georgeh0 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add v0 here?

Copy link
Copy Markdown
Contributor Author

@Haleshot Haleshot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still accept changes pushed to v0?

If so, I can add v0 to both the pull_request and push branch filters. If it is archived/frozen, keeping only main seems cleaner?

Copy link
Copy Markdown
Member

@badmonster0 badmonster0 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgeh0 may take a look?

Copy link
Copy Markdown
Contributor Author

@Haleshot Haleshot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me know :)

paths:
- "docs/**/*.md"
- "docs/**/*.mdx"
- ".lycheeignore"
- ".github/workflows/links.yml"
push:
branches: [main, v1]
branches: [main]
paths:
- "docs/**/*.md"
- "docs/**/*.mdx"
Expand All @@ -33,6 +33,7 @@ jobs:
fetch-depth: 1

- name: Restore lychee cache
if: github.event_name != 'schedule'
uses: actions/cache@v5
with:
path: .lycheecache
Expand All @@ -49,14 +50,14 @@ jobs:
jobSummary: true
output: ./lychee/out.md

- name: Fail on broken links
if: steps.lychee.outputs.exit_code == 1
run: exit 1

- name: Create issue from report
if: steps.lychee.outputs.exit_code == 1
if: steps.lychee.outputs.exit_code == '2' && github.event_name == 'schedule'
uses: peter-evans/create-issue-from-file@v6
with:
title: Link Checker Report
content-filepath: ./lychee/out.md
labels: report, automated issue

- name: Fail on broken links
if: steps.lychee.outputs.exit_code != '0'
run: exit 1
Loading