fix: correct lychee exit code handling#1960
Open
Haleshot wants to merge 2 commits into
Open
Conversation
…eduled runs Signed-off-by: Srihari Thyagarajan <hari.leo03@gmail.com>
…ror on PRs Signed-off-by: Srihari Thyagarajan <hari.leo03@gmail.com>
Contributor
Author
|
The CI fail (expected) is now correctly catching the broken v1 links still in main. Will go green once the doc-fix PR merges: #1959 |
georgeh0
reviewed
May 13, 2026
| on: | ||
| pull_request: | ||
| branches: [main, v1] | ||
| branches: [main] |
Contributor
Author
There was a problem hiding this comment.
Do you still accept changes pushed to v0?
If so, I can add v0 to both the pull_request and push branch filters. If it is archived/frozen, keeping only main seems cleaner?
Contributor
Author
There was a problem hiding this comment.
Sure, let me know :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the link checker workflow that was silently passing despite broken links in the latest run.
Turned out there were a few compounding issues:
lycheeactually exits with 2 for broken links (not 1), so the old== 1condition never fired. The issue creation step also needed to come before the fail step, otherwise it gets skipped.And scheduled runs were restoring a stale cache, so URLs that were valid before the
v1branch was deleted kept passing on daily checks; fixed by skipping cache restore on scheduled runs entirely. Also cleaned up v1 from the branch triggers since that branch no longer exists :)