Add task link cards#1325
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c259948d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-channel-ui
branch
from
b10b82b to
75accc5
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
1c25994 to
0b25615
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b25615c87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
0b25615 to
49cdaf8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49cdaf8bd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
49cdaf8 to
846fab4
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-channel-ui
branch
from
884400a to
0a2d7c7
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
a99845a to
a0d386a
Compare
There was a problem hiding this comment.
💡 Codex Review
Enable task rows whose source message is not cached
When a task marker is in the current history window but the original agent reply is not (for example, an old task with a recent title/summary marker, since the channel query only loads a bounded recent history window), this disables the row's Open action even though the task is listed. That leaves users unable to open the task from the Tasks tab unless they first switch back to Messages and page far enough to load the old source event; use the marker/link IDs to fetch or route to the task instead of requiring message to already be present.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-channel-ui
branch
from
0a2d7c7 to
acf6fa6
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
239d19e to
ea173d7
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-channel-ui
branch
from
acf6fa6 to
070018b
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
ea173d7 to
77dc87f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77dc87f52d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e11797f1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
4e11797 to
ecae89c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecae89c7af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
ecae89c to
fcf9b01
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcf9b01e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
fcf9b01 to
3b8a337
Compare
klopez4212
force-pushed
the
kennylopez-agent-tasks-links
branch
from
3b8a337 to
a153141
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a15314153f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| getThreadAutoRouteAgentPubkeys({ | ||
| currentPubkey, | ||
| knownAgentPubkeys, | ||
| messages: threadSourceMessages, |
There was a problem hiding this comment.
Fresh evidence after the thread auto-route move: this call uses ChannelPane's knownAgentPubkeys, which is built from channel/managed/relay/activity agents and does not include messageProfiles entries where profile.isAgent (the profile-backed routingAgentPubkeys in ChannelScreen is now only used for the DM wrapper). In a one-human/one-agent thread where the agent is known only from the users-batch profile, getThreadAutoRouteAgentPubkeys treats the agent author as another human and returns no auto p tag, so a plain thread reply is missed by mention-filtered ACP agents unless the user manually @mentions it.
Useful? React with 👍 / 👎.
1 participant
Summary
Stack
Snapshots
Task marker and recap
Channel Tasks tab
Tests
git diff --check origin/main..HEADcd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmitcd desktop && pnpm testcargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --lib