Skip to content

Gate channel tasks experiment#1275

Open
klopez4212 wants to merge 7 commits into
kennylopez-agent-tasks-linksfrom
kennylopez-agent-thread-continuous-conversations
Open

Gate channel tasks experiment#1275
klopez4212 wants to merge 7 commits into
kennylopez-agent-tasks-linksfrom
kennylopez-agent-thread-continuous-conversations

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Put the channel Tasks / continued agent conversation surface behind the new channel-tasks Experiments flag.
  • Gate task markers, task tabs, task links, deep links, composer cards, and persisted task state when the experiment is disabled.
  • Keep Gate channel tasks experiment #1275 as the top PR in the stack so the existing review thread remains attached to the final rollout gate.

Stack

  1. Add agent task conversation foundation #1323
  2. Add channel task surface #1324
  3. Add task link cards #1325
  4. This PR

Snapshots

Task marker and recap

Task marker and recap

Channel Tasks tab

Channel Tasks tab

Tests

  • git diff --check origin/main..HEAD
  • cd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmit
  • cd desktop && pnpm test
  • cargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --lib
  • Snapshot capture: cd desktop && pnpm exec playwright test tests/e2e/agent-task-snapshots.spec.ts --project=smoke --config playwright.config.ts using a temporary local spec that was removed before commit.

@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch 2 times, most recently from f727a44 to f45c44f Compare June 26, 2026 17:56
@klopez4212 klopez4212 marked this pull request as ready for review June 26, 2026 17:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f45c44f52b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/agentConversations.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf5fc6687c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/AgentConversationScreen.tsx
Comment thread desktop/src/features/channels/ui/ChannelPane.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b99ec19a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/buzz-acp/src/queue.rs
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch from 9b99ec1 to 69de848 Compare June 27, 2026 08:08
@klopez4212 klopez4212 changed the title Add continued agent conversations Gate channel tasks experiment Jun 27, 2026
@klopez4212 klopez4212 changed the base branch from main to kennylopez-agent-tasks-links June 27, 2026 08:12
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

next.delete(activeAgentConversationChannelId);

P2 Badge Preserve channel unread badges while a task is open

When a task conversation is selected, this drops the entire source channel from the unread ID set based only on the channel id. In the scenario where that channel also has unrelated unread messages, the task screen only marks the task thread messages read, so deleting the channel here hides the sidebar badge/overflow indicator for real unread content until the user leaves the task. Keep the channel unread state visible, or subtract only the task thread’s messages rather than suppressing the whole channel.


onOpenThread(threadMessage);

P2 Badge Scroll to the agent reply from task rows

For markers whose agent reply is inside a thread (parentMessageId is set), the Tasks view switches back to Messages and only opens threadMessage. handleOpenThread clears the thread scroll target, so “Go to message” lands on the thread root/parent rather than the marker’s agentReplyId; in a busy thread the source reply can remain off-screen or hidden. Pass the agent reply as a route/scroll target (or set the thread target to marker.agentReplyId) before returning.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if (marker.parentMessageId) {
onOpenThread(threadMessage);
return;

P2 Badge Target the reply when opening task messages

When a task was started from a reply (marker.parentMessageId is set), the Tasks tab's “Go to message” path opens only threadMessage and returns without setting any scroll/highlight target for the actual task reply. In long threads this lands at the thread head/default position rather than the source reply the button promises to show; route through the existing deep-link target logic or propagate message.id as the thread scroll target after opening the thread.


() => buildTimelineItems(deferredEntries, firstUnreadMessageId),

P2 Badge Build scroll indexes with the same day-divider option

When showInitialDayDivider is false (as in the agent conversation screen), the child list omits the initial divider, but this parent timelineItems call still uses the default that includes it. That makes virtualizerOption.itemCount and indexByMessageId one row larger than the rendered TimelineMessageList, so bottom pinning or target convergence can scroll to the wrong/out-of-range index; pass showInitialDayDivider into this buildTimelineItems call and include it in the deps.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 1c25994 to 0b25615 Compare June 27, 2026 09:07
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch from 7570128 to f07ffd3 Compare June 27, 2026 09:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f07ffd394e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/ChannelPane.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 0b25615 to 49cdaf8 Compare June 27, 2026 09:36
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch from f07ffd3 to 6490e73 Compare June 27, 2026 09:41
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 49cdaf8 to 846fab4 Compare June 27, 2026 09:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6490e73e7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/useAgentConversationRouteTarget.ts Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch 2 times, most recently from 094a9f7 to 090eff6 Compare June 27, 2026 09:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 090eff61e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/useAgentConversationRouteTarget.ts
Comment thread desktop/src/features/messages/lib/useRichTextEditor.ts Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from a99845a to a0d386a Compare June 27, 2026 10:17
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch 2 times, most recently from 210c44e to 7f05400 Compare June 27, 2026 10:29
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 239d19e to ea173d7 Compare June 27, 2026 10:46
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch from 7f05400 to 7d4dba1 Compare June 27, 2026 10:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d4dba1820

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +542 to +543
agentName: taskAgent?.name ?? "",
agentPubkey: taskAgent?.pubkey ?? "",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Defer opening tasks until the agent resolves

When a user clicks New task/Open before the member/managed/relay agent lookups have populated (or for a historical agent that is not in those lists), resolveTaskAgentForMessage returns null and these empty fallbacks create the conversation with no routeable agent. If the user sends the first follow-up in that state, AgentConversationScreen has no routeableAgentPubkeys, so the reply is published without the agent p tag and the ACP subscriber will not receive it. The task deep-link path now waits for agent lookup readiness; the click path should do the same or fall back to the marker/source agent instead of opening with empty agent fields.

Useful? React with 👍 / 👎.

@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from ea173d7 to 77dc87f Compare June 27, 2026 11:03
@klopez4212 klopez4212 force-pushed the kennylopez-agent-thread-continuous-conversations branch from 7d4dba1 to 26e47c8 Compare June 27, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant