Gate channel tasks experiment#1275
Conversation
f727a44 to
f45c44f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f45c44f52b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf5fc6687c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b99ec19a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9b99ec1 to
69de848
Compare
💡 Codex ReviewWhen a task conversation is selected, this drops the entire source channel from the unread ID set based only on the channel id. In the scenario where that channel also has unrelated unread messages, the task screen only marks the task thread messages read, so deleting the channel here hides the sidebar badge/overflow indicator for real unread content until the user leaves the task. Keep the channel unread state visible, or subtract only the task thread’s messages rather than suppressing the whole channel. For markers whose agent reply is inside a thread ( ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
buzz/desktop/src/features/channels/ui/ChannelPane.tsx
Lines 572 to 574 in 7570128
When a task was started from a reply (marker.parentMessageId is set), the Tasks tab's “Go to message” path opens only threadMessage and returns without setting any scroll/highlight target for the actual task reply. In long threads this lands at the thread head/default position rather than the source reply the button promises to show; route through the existing deep-link target logic or propagate message.id as the thread scroll target after opening the thread.
When showInitialDayDivider is false (as in the agent conversation screen), the child list omits the initial divider, but this parent timelineItems call still uses the default that includes it. That makes virtualizerOption.itemCount and indexByMessageId one row larger than the rendered TimelineMessageList, so bottom pinning or target convergence can scroll to the wrong/out-of-range index; pass showInitialDayDivider into this buildTimelineItems call and include it in the deps.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1c25994 to
0b25615
Compare
7570128 to
f07ffd3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f07ffd394e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0b25615 to
49cdaf8
Compare
f07ffd3 to
6490e73
Compare
49cdaf8 to
846fab4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6490e73e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
094a9f7 to
090eff6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 090eff61e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a99845a to
a0d386a
Compare
210c44e to
7f05400
Compare
239d19e to
ea173d7
Compare
7f05400 to
7d4dba1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d4dba1820
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| agentName: taskAgent?.name ?? "", | ||
| agentPubkey: taskAgent?.pubkey ?? "", |
There was a problem hiding this comment.
Defer opening tasks until the agent resolves
When a user clicks New task/Open before the member/managed/relay agent lookups have populated (or for a historical agent that is not in those lists), resolveTaskAgentForMessage returns null and these empty fallbacks create the conversation with no routeable agent. If the user sends the first follow-up in that state, AgentConversationScreen has no routeableAgentPubkeys, so the reply is published without the agent p tag and the ACP subscriber will not receive it. The task deep-link path now waits for agent lookup readiness; the click path should do the same or fall back to the marker/source agent instead of opening with empty agent fields.
Useful? React with 👍 / 👎.
ea173d7 to
77dc87f
Compare
7d4dba1 to
26e47c8
Compare
Summary
channel-tasksExperiments flag.Stack
Snapshots
Task marker and recap
Channel Tasks tab
Tests
git diff --check origin/main..HEADcd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmitcd desktop && pnpm testcargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --libcd desktop && pnpm exec playwright test tests/e2e/agent-task-snapshots.spec.ts --project=smoke --config playwright.config.tsusing a temporary local spec that was removed before commit.