Skip to content

test: improve round sqllogictest coverage #23973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilconway merged 5 commits into from
Jul 30, 2026
+96 −0
Merged

test: improve round sqllogictest coverage #23973

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e95d4b
test: improve round SQL coverage
2010YOUY01 Jul 21, 2026
ef7f043
tighten error message check
2010YOUY01 Jul 30, 2026
0336eb6
fix ci
2010YOUY01 Jul 30, 2026
305dcb8
fix ci
2010YOUY01 Jul 30, 2026
a3ec567
more coverage to no null columns
2010YOUY01 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions datafusion/sqllogictest/test_files/math.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,102 @@ SELECT round(125.2345, -3), round(125.2345, -2), round(125.2345, -1), round(125.
----
0 100 130 125 125 125.2 125.23 125.235

# Round signed and unsigned integer scalar widths
query IIIIIIII
SELECT
round(arrow_cast('115', 'Int8'), -1),
round(arrow_cast('-115', 'Int16'), -1),
round(arrow_cast('115', 'Int32'), -1),
round(arrow_cast('-115', 'Int64'), -1),
round(arrow_cast('115', 'UInt8'), -1),
round(arrow_cast('115', 'UInt16'), -1),
round(arrow_cast('115', 'UInt32'), -1),
round(arrow_cast('115', 'UInt64'), -1);
----
120 -120 120 -120 120 120 120 120

# Round signed and unsigned integer arrays, including null and oversized scales

@neilconway neilconway Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd benefit from another test row that checks oversized scales but does not have a NULL in column1 (since NULLs take a different code path). e.g., ('115', -20)

@2010YOUY01 2010YOUY01 Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updated.

query IIIIIIII
SELECT
round(arrow_cast(column1, 'Int8'), column2),
round(arrow_cast(column1, 'Int16'), column2),
round(arrow_cast(column1, 'Int32'), column2),
round(arrow_cast(column1, 'Int64'), column2),
round(arrow_cast(column1, 'UInt8'), column2),
round(arrow_cast(column1, 'UInt16'), column2),
round(arrow_cast(column1, 'UInt32'), column2),
round(arrow_cast(column1, 'UInt64'), column2)
FROM (VALUES ('115', -1), ('0', -1), (NULL, -20)) AS t(column1, column2);
----
120 120 120 120 120 120 120 120
0 0 0 0 0 0 0 0
NULL NULL NULL NULL NULL NULL NULL NULL

# Test columns without null
query I
SELECT
round(column1, column2)
FROM (VALUES (115, -20), (0, -1), (21, -1)) AS t(column1, column2);
----
0
0
20

# Round all decimal widths as scalars
query RRRR
SELECT
round(arrow_cast('125.55', 'Decimal32(7,2)'), 1),
round(arrow_cast('-125.55', 'Decimal64(16,2)'), 1),
round(arrow_cast('125.55', 'Decimal128(30,2)'), 1),
round(arrow_cast('-125.55', 'Decimal256(40,2)'), 1);
----
125.6 -125.6 125.6 -125.6

# Round all decimal widths as arrays with per-row decimal places
query RRRR
SELECT
round(arrow_cast(column1, 'Decimal32(7,2)'), column2),
round(arrow_cast(column1, 'Decimal64(16,2)'), column2),
round(arrow_cast(column1, 'Decimal128(30,2)'), column2),
round(arrow_cast(column1, 'Decimal256(40,2)'), column2)
FROM (VALUES ('125.55', 1), ('-125.55', 0), ('125.55', -1), (NULL, 1)) AS t(column1, column2);
----
125.6 125.6 125.6 125.6
-126 -126 -126 -126
130 130 130 130
NULL NULL NULL NULL

# Float arrays with scalar and per-row decimal places
query RRRR
SELECT
round(arrow_cast(column1, 'Float32'), 1),
round(arrow_cast(column1, 'Float64'), 1),
round(arrow_cast(column1, 'Float32'), column2),
round(arrow_cast(column1, 'Float64'), column2)
FROM (VALUES ('125.55', 1), ('-125.55', 0), (NULL, -1)) AS t(column1, column2);
----
125.6 125.6 125.6 125.6
-125.6 -125.6 -126 -126
NULL NULL NULL NULL

# Null decimal places, invalid argument count/type, and out-of-range scale
query R
SELECT round(1.25, NULL);
----
NULL

query error DataFusion error: Error during planning: 'round' does not support zero arguments
SELECT round();

query error Error during planning: Internal error: Function 'round' failed to match any signature
SELECT round(1, 2, 3);

query error Error during planning: Internal error: Function 'round' failed to match any signature
SELECT round('x');

query error round decimal_places 2147483648 is out of supported i32 range
SELECT round(1.25, 2147483648);

# atan2
query RRRRRRR
SELECT atan2(2.0, 1.0), atan2(-2.0, 1.0), atan2(2.0, -1.0), atan2(-2.0, -1.0), atan2(NULL, 1.0), atan2(2.0, NULL), atan2(NULL, NULL);
Expand Down
Loading