Skip to content

[on june 22, 2026, current gptoss submiters were given notice that it will be deprepcated on july 6th, and were given an chance for comment period and everyone reacted notice] Deprecate gpt-oss-120b benchmark configs / 弃用 gpt-oss-120b 基准测试配置#2101

Merged
functionstackx merged 1 commit into
mainfrom
klaud/deprecate-gptoss
Jul 6, 2026

Conversation

@functionstackx

@functionstackx functionstackx commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

on june 22, 2026, current gptoss submiters were given notice that it will be deprepcated on july 6th, and were given an chance for comment period and everyone reacted with :ack: and ✅ to the notice

Summary

⚠️ Heads-up: open PR #2051 ("gpt-oss-fp4-mi355x W4A8 MoE optimizations") modifies gptoss-fp4-mi355x-vllm, which this PR removes — merging this deprecation supersedes/conflicts with #2051. Decide which one proceeds.

中文说明

🤖 Generated with Claude Code

Following the MiniMax M2.5/M2.7 deprecation pattern (#1874): all 10
gptoss config entries removed from the active master configs and
archived under configs/deprecated/{nvidia,amd}-gptoss-master.yaml; the
9 single-node scripts and the gb200 dynamo-trt multi-node script moved
into deprecated/ subdirectories. Unlike #1874, the moved scripts'
benchmark_lib.sh source paths are corrected for the extra directory
level (the #1860 bug class).

中文:按 MiniMax M2.5/M2.7 弃用模式(#1874)弃用 gpt-oss-120b 基准
测试配置 - 10 个配置条目从活动 master 配置中移除并归档至
configs/deprecated/,全部脚本移入 deprecated/ 子目录;与 #1874 不同,
本次已同步修正移动脚本中 benchmark_lib.sh 的相对引用路径。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

1 similar comment
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@functionstackx functionstackx changed the title [Klaud Cold] Deprecate gpt-oss-120b benchmark configs / 弃用 gpt-oss-120b 基准测试配置 [on june 22, 2026, current gptoss submiters were given notice that it will be deprepcated on july 6th, and were given an chance for comment period and everyone reacted notice] Deprecate gpt-oss-120b benchmark configs / 弃用 gpt-oss-120b 基准测试配置 Jul 6, 2026
@functionstackx functionstackx merged commit 4699ab8 into main Jul 6, 2026
14 checks passed
@functionstackx functionstackx deleted the klaud/deprecate-gptoss branch July 6, 2026 19:05

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — mechanical deprecation following the #1874 pattern (config entries archived to configs/deprecated/, scripts moved with correctly-adjusted benchmark_lib.sh paths).

Extended reasoning...

Overview

Deprecates 10 gpt-oss-120b benchmark recipes: 10 config entries removed from active configs/amd-master.yaml and configs/nvidia-master.yaml and archived verbatim under new configs/deprecated/{amd,nvidia}-gptoss-master.yaml files, and the 10 corresponding shell scripts git mv-ed into deprecated/ subdirectories (9 single_node/fixed_seq_len + 1 multi_node). Also strips some blank-line whitespace between neighboring YAML entries.

Security risks

None. This is a config/benchmark-recipe deprecation touching only sweep definitions and their launch scripts. No auth, crypto, permissions, or user-facing surfaces are involved.

Level of scrutiny

Low. The changes are purely mechanical: identical YAML blocks moved between files, and shell scripts moved into a subdirectory with ../../benchmark_lib.sh../../../benchmark_lib.sh adjustments to compensate for the extra directory level. Sweep generation only reads configs/{amd,nvidia}-master.yaml (verified via .claude/mcp/mcp_utils.py), so archived entries under configs/deprecated/ won't be selected. This follows the established pattern from #1874 (MiniMax M2.5/M2.7 deprecation) with a small improvement — the relative source paths in the archived scripts are actually correct here, whereas M2.5's archived scripts still carry stale paths (dormant, since they're archive-only).

Other factors

No bugs were flagged by the bug hunting system. No perf-changelog.yaml entry is needed for a deprecation (matches #1874 precedent — removals don't trigger sweeps). The PR description explicitly flags a coordination concern with open PR #2051 (which modifies gptoss-fp4-mi355x-vllm, an entry this PR removes) — that's a merge-ordering call a human can make when picking which to merge first, not a code-correctness issue with this PR. Some historical launcher-dispatch code in runners/launch_*.sh still references gptoss as a supported MODEL_PREFIX, but since nothing in the active configs sets that prefix anymore, the branch is dormant and harmless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant