Fix honest inventory argv compile spine (#15597) by PurHur · Pull Request #15615 · PurHur/php-compiler

PurHur · 2026-07-03T20:10:14Z

Summary

Path-key stale compiler_lib sidecars when stamp drifts (no byte-identical source match)
Real-lower Runtime ctor/init for inventory argv when PHP_COMPILER_M3_COMPILE_DRIVER=1 (standalone stays stubbed)
Guard emitPutenvM3CompileDriverMainForBootstrapSelfhost with ensureOpenInsertBlock (fixes BasicBlockHelper crash during driver relink)

Test plan

vendor/bin/phpunit --filter M3EmitTuCompileDriverGateTest
Docker inventory driver rebuild (bin/compile.php → build/bin-compile-aot-inventory) — needs 8GB+ container memory
./script/bootstrap-loop-probe.sh --honest-compile green

Closes #15597 when honest gate passes.

Made with Cursor

Fixture-level gen-2 compile probe patches a sentinel marker, verifies binary hash or stdout delta, and documents lib/ incremental changed-tree as future work. Co-authored-by: Cursor <cursoragent@cursor.com>

…5605 #15606). Flip default onboarding to phpc bootstrap init and tiered workflow docs; add bootstrap-sdk-platform contract; surface pointers in README, GETTING-STARTED, and phpc doctor --selfhost. Co-authored-by: Cursor <cursoragent@cursor.com>

Wire phpc lint --native to gen-2 driver -l with Zend fallback, add bootstrap-sdk-pack tarball script and unit tests for both paths. Co-authored-by: Cursor <cursoragent@cursor.com>

Path-key stale compiler_lib sidecars by source path, real-lower Runtime init when M3 compile driver is on, and guard putenv emit with an open BB. Co-authored-by: Cursor <cursoragent@cursor.com>

findOffsetI32 may clear the builder position via ensureBridge; re-open the insert block before appending branch targets. Co-authored-by: Cursor <cursoragent@cursor.com>

PurHur · 2026-07-03T22:01:21Z

Maintainer review (2026-07-03): Test plan item bootstrap-loop-probe.sh --honest-compile still unchecked — hold merge until honest compile gate passes per #15597. Bootstrap link + helloworld green on master.

PurHur · 2026-07-04T04:45:31Z

Maintainer triage 2026-07-04: unit gate (M3EmitTuCompileDriverGateTest) claimed green; Docker inventory rebuild + bootstrap-loop-probe --honest-compile still unchecked. Holding merge until #15597 honest gate verified locally.

PurHur · 2026-07-04T05:15:05Z

Maintainer triage 2026-07-04: bootstrap-selfhost-link + helloworld green on master. PR bundles gen-1+ docs/tooling beyond #15597 core — please split or confirm scope. Honest compile Docker gate (bootstrap-loop-probe --honest-compile) not re-verified this run; hold merge until that checkbox is green.

PurHur · 2026-07-04T08:54:15Z

Maintainer review (2026-07-04): Not merge-ready this run — PR checklist shows Docker inventory driver rebuild + bootstrap-loop-probe --honest-compile still unchecked. Bootstrap link/helloworld green on master; hold merge until honest compile gate verified locally.

PurHur · 2026-07-04T09:27:47Z

Maintainer triage (2026-07-04): Holding merge — test plan still has unchecked Docker inventory driver rebuild and ./script/bootstrap-loop-probe.sh --honest-compile. M3 unit gate passes per PR body; please confirm honest-compile green before merge. Master bootstrap: bootstrap-selfhost-link + bootstrap-selfhost-helloworld green on harness today.

Note: PR bundles gen-1+ doc/SDK commits beyond #15597 spine fix — consider splitting if review surface is large.

PurHur · 2026-07-04T09:53:24Z

Maintainer triage 2026-07-04: M3EmitTuCompileDriverGateTest passes on master (21 assertions). PR test plan still lists unchecked Docker inventory rebuild + ./script/bootstrap-loop-probe.sh --honest-compile. Branch also bundles gen-1+ onboarding/docs (#15605–#15606) unrelated to #15597 — consider splitting before merge. Holding merge until honest-compile gate is verified green on the PR branch.

PurHur · 2026-07-04T10:36:14Z

Maintainer triage (2026-07-04) — bootstrap gates on master:

Gate	Status
`bootstrap-selfhost-gate.sh link`	✅ OK
`bootstrap-selfhost-gate.sh helloworld`	✅ Hello World
`bootstrap-inventory.php --check`	⚠️ file-list drift (Compiler.php +4 methods; doc regen needed)

Merge hold: Test plan still has unchecked Docker inventory driver rebuild and ./script/bootstrap-loop-probe.sh --honest-compile. PR also bundles onboarding/docs for #15605/#15606/#15601/#15602 — please split or confirm intentional scope before merge.

Re-run honest gate locally once lock clears; will merge when --honest-compile is green on the branch.

PurHur · 2026-07-04T11:10:26Z

Maintainer triage 2026-07-04: bootstrap link + helloworld green on master. Honest-compile gate (bootstrap-loop-probe --honest-compile) still unchecked in test plan — hold merge until Docker inventory driver rebuild verified locally.

PurHur · 2026-07-04T18:14:01Z

Maintainer triage (2026-07-04): Target issue #15597 is already closed on master. PR still open with doc/tooling sidecars (#15601/#15602) beyond the spine fix.

Before merge: rebase onto current master, confirm `Closes #15597` is still accurate (or retarget), and run honest-compile gate from test plan:
```bash
./script/bootstrap-loop-probe.sh --honest-compile
```
Bootstrap gates on maintainer host today: `bootstrap-selfhost-link` + `helloworld` green; inventory `--check` reports doc drift only (`ext/dom/ElementInsertAdjacentHTML.php` path delta).

PurHur · 2026-07-04T19:59:03Z

Maintainer triage 2026-07-04: checked out branch locally — vendor/bin/phpunit --filter M3EmitTuCompileDriverGateTest green; ./script/bootstrap-loop-probe.sh --honest-compile --dry-run green through M4 gen-2 emit.

Still blocked on PR test-plan items: full Docker inventory driver rebuild (bin/compile.php → build/bin-compile-aot-inventory, 8GB+) and ./script/bootstrap-loop-probe.sh --honest-compile (non-dry-run). Please tick those before merge.

PurHur · 2026-07-05T00:08:04Z

Maintainer verification (2026-07-05)

Bootstrap gates (host, before review):

`bootstrap-selfhost-link`: green
`bootstrap-selfhost-helloworld`: green (`Hello World`)
`bootstrap-inventory.php --check`: green (doc drift warning only: +2 vm.php-path files)

This PR (checked out `feat/15597-honest-full-spine-compile` @ 4fadd7b):

`vendor/bin/phpunit --filter M3EmitTuCompileDriverGateTest`: green (1 test, 22 assertions)

Not run this pass: Docker inventory argv rebuild / `bootstrap-loop-probe.sh --honest-compile` (8GB+; required before merge per PR test plan).

Status: keep open — unit gate green, honest compile spine gate still unchecked. Please re-request review after honest gate is green locally.

PurHur · 2026-07-05T01:40:07Z

Maintainer triage 2026-07-05: not merging yet — test plan still has unchecked Docker inventory driver rebuild and ./script/bootstrap-loop-probe.sh --honest-compile. On master, M3EmitTuCompileDriverGateTest passes in Docker; please confirm honest-compile gate green before merge request.

Bootstrap on master: link + helloworld green.

PurHur · 2026-07-05T06:36:07Z

Maintainer triage (2026-07-05): do not merge yet.

Closes Gen-1+ #1: Honest full-spine native compile without gen-0 sidecar fallback #15597 which is already closed on master — please reconcile (retarget/respin issue or update PR body).
Test plan still has unchecked Docker inventory driver rebuild + ./script/bootstrap-loop-probe.sh --honest-compile.
Local bootstrap gates on master are green (bootstrap-selfhost-link, bootstrap-selfhost-helloworld); re-run honest-compile repro on this branch before merge request.

Ping when green + issue link is corrected.

PurHur · 2026-07-05T07:17:53Z

Maintainer triage 2026-07-05: test plan still has unchecked Docker inventory driver rebuild and bootstrap-loop-probe.sh --honest-compile. Master bootstrap link + helloworld green; hold merge until honest-compile gate verified on branch.

PurHur · 2026-07-05T07:56:04Z

Maintainer triage 2026-07-05: Master bootstrap green (bootstrap-selfhost-link, bootstrap-selfhost-helloworld). Holding merge — test plan still unchecked for Docker inventory driver rebuild + bootstrap-loop-probe --honest-compile. Linked issue #15597 is closed; please rebase/retarget or split gen-1+ doc/SDK scope before merge.

PurHur · 2026-07-05T09:09:00Z

Maintainer triage 2026-07-05: not merging yet — PR test plan still has unchecked Docker inventory rebuild and ./script/bootstrap-loop-probe.sh --honest-compile. Bootstrap link + helloworld gates are green on master; please tick honest-compile + narrow probe before merge request.

make bootstrap-selfhost-link / bootstrap-selfhost-helloworld: green in harness.

PurHur and others added 5 commits July 3, 2026 21:49

Add bootstrap changed-tree probe scaffold for #15598.

4945d6b

Fixture-level gen-2 compile probe patches a sentinel marker, verifies binary hash or stdout delta, and documents lib/ incremental changed-tree as future work. Co-authored-by: Cursor <cursoragent@cursor.com>

Add native lint and Bootstrap SDK pack starter (#15601 #15602)

6c6f6b9

Wire phpc lint --native to gen-2 driver -l with Zend fallback, add bootstrap-sdk-pack tarball script and unit tests for both paths. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix honest inventory argv compile spine for #15597.

4862e29

Path-key stale compiler_lib sidecars by source path, real-lower Runtime init when M3 compile driver is on, and guard putenv emit with an open BB. Co-authored-by: Cursor <cursoragent@cursor.com>

Restore LLVM insert block after JitVmHelperLink in putenv emit (#15597).

4fadd7b

findOffsetI32 may clear the builder position via ensureBridge; re-open the insert block before appending branch targets. Co-authored-by: Cursor <cursoragent@cursor.com>

PurHur mentioned this pull request Jul 4, 2026

chore: drop stale maintainer_gap repros for closed issues (jul04 wave20) #15970

Merged

2 tasks

PurHur mentioned this pull request Jul 5, 2026

chore: drop stale maintainer_gap repros for closed issues (jul05 wave22) #16416

Merged

2 tasks

Conversation

PurHur commented Jul 3, 2026

Summary

Test plan

Uh oh!

PurHur commented Jul 3, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 4, 2026

Uh oh!

PurHur commented Jul 5, 2026

Maintainer verification (2026-07-05)

Uh oh!

PurHur commented Jul 5, 2026

Uh oh!

PurHur commented Jul 5, 2026

Uh oh!

PurHur commented Jul 5, 2026

Uh oh!

PurHur commented Jul 5, 2026

Uh oh!

PurHur commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant