Bump Onyx to 3.0.89 by fabioh8010 · Pull Request #93436 · Expensify/App

fabioh8010 · 2026-06-12T13:37:26Z

Explanation of Change

Bumps Onyx to 3.0.89, which includes this changes:

Remove waitForCollectionCallback from Onyx react-native-onyx#799

Fixed Issues

$ #94331
PROPOSAL:

Tests

We are basically just removing waitForCollectionCallback usage here, functionality should stay the same so we only need to test the two files where we actually did some meaningful change (Report/index.ts and replaceOptimisticReportWithActualReport.ts).

Go to Offline mode.
Start a chat with an user that exists but you never messaged before.
Send a message to that user.
Go back to Online mode, assert the message is still there and the user is still the correct one.
Delete the message you just sent, assert it works.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-06-30.at.08.46.47.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-30.at.08.40.31.mov

…onyx-store-poc-baseline

github-actions · 2026-06-12T13:37:36Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

(cherry picked from commit 535279b)

The waitForCollectionCallback connect option no longer exists in Onyx store-based PR 1, so remove all usages across the app. Collection-root subscriptions now always deliver snapshots, so the now-properly-typed snapshot callbacks no longer need the `as unknown as Record<...>` casts; rebuild the rawID-keyed views with a plain `.replace()`. Also fix a couple of resulting test type errors: type the collected collection vars in ReportTest as non-undefined, and cast the resolved value in the getOnyxValue single-key helper.

codecov · 2026-06-12T17:05:55Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/DistanceRequestUtils.ts	`87.60% <ø> (-0.43%)`	⬇️
src/libs/Fullstory/common.ts	`0.00% <ø> (ø)`
src/libs/Middleware/Pagination.ts	`98.41% <ø> (ø)`
src/libs/Notification/LocalNotification/index.ts	`0.00% <ø> (ø)`
...ion/PushNotification/shouldShowPushNotification.ts	`30.76% <ø> (ø)`
src/libs/OptionsListUtils/index.ts	`86.07% <ø> (ø)`
src/libs/Parser.ts	`93.10% <ø> (ø)`
src/libs/ReportActionsUtils.ts	`78.41% <ø> (ø)`
src/libs/ReportTitleUtils.ts	`100.00% <ø> (ø)`
src/libs/ReportUtils.ts	`86.93% <ø> (ø)`
... and 18 more
... and 9 files with indirect coverage changes

…onyx-store-poc-baseline

…e-pr-1

…e-pr-1 # Conflicts: # package-lock.json # package.json # src/libs/actions/SplitExpenses.ts

fabioh8010 · 2026-06-24T12:51:48Z

@codex review

chatgpt-codex-connector · 2026-06-24T12:58:37Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 40c913fd89

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…e-pr-1 # Conflicts: # src/libs/actions/Transaction.ts

…e-pr-1 # Conflicts: # package-lock.json # package.json # src/libs/IOUAmountSubmission.ts # src/libs/actions/Policy/Policy.ts # src/libs/actions/Report/index.ts # src/libs/actions/replaceOptimisticReportWithActualReport.ts # tests/actions/IOUTest/SplitTest.ts # tests/utils/getOnyxValue.ts

melvin-bot · 2026-07-07T13:36:46Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-07-07T15:25:45Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

truph01 · 2026-07-08T12:25:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-07-08.at.22.04.16.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-08.at.21.55.04.mov

mountiny · 2026-07-08T14:27:32Z

conflicts

# Conflicts: # src/libs/actions/Report/index.ts

mountiny · 2026-07-08T14:43:58Z

@truph01 any eta? thanks

truph01 · 2026-07-08T15:07:04Z

@truph01 any eta? thanks

@mountiny I just finished reviewing and testing the PR. Everything looks good and works as expected.

mountiny

Thank you!

OSBotify · 2026-07-08T15:37:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-08T16:07:29Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-08T16:20:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93436.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8001e3c7c4a-ee2dd9f-fe62a3b0bdfcf3a4f1694d87ced58ce9237f78b8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8001e3c-ee2dd9f-f3d05acb0f666b450fc30a1f5f64d1d3a6dbd5dd/index.html

Web 🕸️
https://93436.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…ature/onyx-store-pr-1" This reverts commit 8001e3c, reversing changes made to 1276413.

The revert of PR Expensify#93436 reintroduced a namespace import in src/libs/actions/Report/index.ts and a redundant type assertion in tests/actions/IOUTest/SplitTest.ts, pushing both files over their eslint-seatbelt error budgets and breaking lint on main. Co-authored-by: Cursor <cursoragent@cursor.com>

Reverts the coalescing engine that caused deploy blockers, scoped to just the OnyxDerived changes on top of current main. Restores the synchronous, per- dependency recompute engine (Onyx sourceValue based) and keeps waitForCollectionCallback, matching main's current Onyx 3.0.86 (the onyx-store work that removed it, #93436, was already reverted separately). Removes getCollectionDelta, scheduleMacrotask, and the triggeredKeys/flush changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fabioh8010 added 6 commits May 19, 2026 08:53

Bump Onyx to 3.0.75

27c4e07

Remove Onyx patch

cd5720f

Merge branch 'main' into feature/onyx-store-poc-baseline

8fb2246

Merge commit '321ab1822add112c84f386094bc4f1dd7ef21559' into feature/…

2b8620f

…onyx-store-poc-baseline

Merge branch 'main' into feature/onyx-store-poc-baseline

16d2a26

Merge branch 'main' into feature/onyx-store-poc-baseline

9ad61c3

melvin-bot Bot assigned fabioh8010 Jun 12, 2026

fabioh8010 added 3 commits June 12, 2026 17:31

Use newest Onyx changes from Onyx store-based PR 1

71eea11

Refactor collection key Onyx.connect cases

7eecb00

(cherry picked from commit 535279b)

fabioh8010 force-pushed the feature/onyx-store-pr-1 branch from 04ce43b to 6008df2 Compare June 12, 2026 17:00

fabioh8010 added 9 commits June 15, 2026 11:25

Fix lint error

4b9ab27

Merge remote-tracking branch 'origin/main' into feature/onyx-store-pr-1

98048b4

Merge commit '7224b837ffd63958ddceebe1cbc50030fd3a7de1' into feature/…

1f28d58

…onyx-store-poc-baseline

Merge branch 'main' into feature/onyx-store-poc-baseline

52ec1ed

Merge branch 'main' into feature/onyx-store-poc-baseline

047f1a6

Merge branch 'main' into feature/onyx-store-poc-baseline

4b917a5

Merge branch 'feature/onyx-store-poc-baseline' into feature/onyx-stor…

3140e16

…e-pr-1

Merge branch 'main' into feature/onyx-store-poc-baseline

97c35ba

Merge branch 'feature/onyx-store-poc-baseline' into feature/onyx-stor…

40c913f

…e-pr-1 # Conflicts: # package-lock.json # package.json # src/libs/actions/SplitExpenses.ts

fabioh8010 added 5 commits June 24, 2026 14:34

Cleanup

d29d95a

Merge branch 'main' into feature/onyx-store-poc-baseline

9f0dd6e

Use newest Onyx changes

946d782

Use newest Onyx changes

18e015e

Merge branch 'feature/onyx-store-poc-baseline' into feature/onyx-stor…

48d2782

…e-pr-1 # Conflicts: # src/libs/actions/Transaction.ts

fabioh8010 mentioned this pull request Jun 26, 2026

Remove waitForCollectionCallback from Onyx Expensify/react-native-onyx#799

Merged

42 tasks

fabioh8010 changed the title ~~Remove waitForCollectionCallback from Onyx~~ Bump Onyx to 3.0.89 Jul 7, 2026

fabioh8010 marked this pull request as ready for review July 7, 2026 13:36

fabioh8010 requested review from a team as code owners July 7, 2026 13:36

melvin-bot Bot requested review from joekaufmanexpensify and truph01 and removed request for a team July 7, 2026 13:36

melvin-bot Bot removed the request for review from a team July 7, 2026 13:36

mountiny self-requested a review July 7, 2026 15:24

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into feature/onyx-store-pr-1

4932ce8

# Conflicts: # src/libs/actions/Report/index.ts

truph01 approved these changes Jul 8, 2026

View reviewed changes

mountiny approved these changes Jul 8, 2026

View reviewed changes

mountiny merged commit 8001e3c into Expensify:main Jul 8, 2026
43 checks passed

fabioh8010 mentioned this pull request Jul 8, 2026

[Due for payment 2026-07-17] [$250] Collapse Onyx collection-key subscriptions to a single whole-collection delivery mode and remove the waitForCollectionCallback option #94331

Open

mountiny mentioned this pull request Jul 9, 2026

[NoQA] Revert onyx bump #95665

Merged

53 tasks

shubham1206agra pushed a commit to shubham1206agra/App that referenced this pull request Jul 9, 2026

Revert "Merge pull request Expensify#93436 from callstack-internal/fe…

e6b8b0f

…ature/onyx-store-pr-1" This reverts commit 8001e3c, reversing changes made to 1276413.

mountiny mentioned this pull request Jul 9, 2026

[NoQA] Fix ESLint seatbelt budget violations reintroduced by revert #95671

Merged

53 tasks

Uh oh!

Conversation

fabioh8010 commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

codecov Bot commented Jun 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fabioh8010 commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 24, 2026

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

This comment has been minimized.

truph01 commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny commented Jul 8, 2026

Uh oh!

mountiny commented Jul 8, 2026

Uh oh!

truph01 commented Jul 8, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fabioh8010 commented Jun 12, 2026 •

edited

Loading

codecov Bot commented Jun 12, 2026 •

edited by github-actions Bot

Loading

truph01 commented Jul 8, 2026 •

edited

Loading