[NoQA] Revert onyx bump by mountiny · Pull Request #95665 · Expensify/App

mountiny · 2026-07-09T08:22:15Z

Explanation of Change

Reverts #93436

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/657345
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

On web, open the New Expensify sign-in page and enter an SSO / SAML-required account.
Complete sign-in at your identity provider.
Verify you land in the app signed in, and are NOT bounced back to the IdP or stuck on a loading screen that keeps redirecting.
Verify the browser URL does not cycle between/transition,/sign-in-with-saml, and the IdP.

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…x-store-pr-1" This reverts commit 8001e3c, reversing changes made to 1276413.

melvin-bot · 2026-07-09T08:22:21Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbac9056ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

grgia

revert linked should be #93436 @mountiny

mountiny · 2026-07-09T08:53:30Z

Updated

github-actions · 2026-07-09T08:54:59Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-07-09T08:58:39Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

huult · 2026-07-09T09:00:23Z

@mountiny Just wanted to check, did you assign this PR to me by mistake?

github-actions · 2026-07-09T09:02:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95665.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ec5ec823b55-af7837c-2d94acd85bbe1af274b50076f9a1111ed9990710/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ec5ec82-af7837c-ef7ccf4dd46587810fb8e3c8044c9e683d46bd19/index.html

Web 🕸️
https://95665.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2026-07-09T09:04:36Z

Straight revert

mountiny · 2026-07-09T09:05:02Z

@huult We will CP this revert to production and I would love to ask you to test the redirect loop there

OSBotify · 2026-07-09T11:07:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:09:02Z

🤖 Help site review: no changes required

I reviewed the changes in this PR against the help site content under App/docs/articles.

This is a [NoQA] revert of a react-native-onyx dependency bump (reverts #93436). The diff consists entirely of:

A react-native-onyx version change in package.json / package-lock.json
Mechanical internal adjustments to useOnyx calls (re-adding canBeMissing-style params) across src/libs/**
Corresponding updates to unit/action test files under tests/**

None of this touches user-facing features, UI labels, tab names, settings, or documented product behavior. Help site articles describe product functionality, and a dependency-version revert has no documentation impact — so no draft docs PR is needed.

If there's a specific user-facing behavior change tied to this revert that I've missed, let me know and I'll re-scope.

huult · 2026-07-09T15:02:49Z

@huult We will CP this revert to production and I would love to ask you to test the redirect loop there

Slack.

@mountiny We've finished testing the redirect loop issue. Is there anything else you'd like me to do?

mountiny · 2026-07-09T18:39:48Z

@MelvinBot Can you create App payment issue for @huult for $125 please and link this PR

MelvinBot · 2026-07-09T18:43:13Z

🤖 Created the App payment issue for huult ($125), linked to this PR: #95746

OSBotify · 2026-07-10T13:44:47Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Revert "Merge pull request #93436 from callstack-internal/feature/ony…

e6b8b0f

…x-store-pr-1" This reverts commit 8001e3c, reversing changes made to 1276413.

mountiny requested a review from huult July 9, 2026 08:22

mountiny self-assigned this Jul 9, 2026

mountiny requested review from a team as code owners July 9, 2026 08:22

melvin-bot Bot requested review from bernhardoj and removed request for a team July 9, 2026 08:22

melvin-bot Bot requested review from flaviadefaria and removed request for a team July 9, 2026 08:22

mountiny changed the title ~~Revert onyx bumps~~ [CP Both] Revert onyx bumps Jul 9, 2026

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread tests/utils/getOnyxValue.ts

MonilBhavsar previously approved these changes Jul 9, 2026

View reviewed changes

mountiny changed the title ~~[CP Both] Revert onyx bumps~~ [HOLD] Revert onyx bumps Jul 9, 2026

mountiny dismissed MonilBhavsar’s stale review via e6b8b0f July 9, 2026 08:48

mountiny force-pushed the vit-revertOnyxBumps branch from dbac905 to e6b8b0f Compare July 9, 2026 08:48

mountiny changed the title ~~[HOLD] Revert onyx bumps~~ [NoQA] Revert onyx bump Jul 9, 2026

grgia approved these changes Jul 9, 2026

View reviewed changes

MonilBhavsar approved these changes Jul 9, 2026

View reviewed changes

mountiny merged commit ec5ec82 into main Jul 9, 2026
44 of 46 checks passed

mountiny deleted the vit-revertOnyxBumps branch July 9, 2026 08:53

melvin-bot Bot added the Emergency label Jul 9, 2026

mountiny removed the Emergency label Jul 9, 2026

github-actions Bot mentioned this pull request Jul 9, 2026

Investigate workflow job failing on main: lint / ESLint check #95669

Closed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

MelvinBot mentioned this pull request Jul 9, 2026

[Due for Payment 2026-07-16] [$125] to @huult for https://github.com/Expensify/App/pull/95665 #95746

Open

fabioh8010 mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-17] [$250] Collapse Onyx collection-key subscriptions to a single whole-collection delivery mode and remove the waitForCollectionCallback option #94331

Open

Uh oh!

Conversation

mountiny commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jul 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

huult commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

mountiny commented Jul 9, 2026

Uh oh!

mountiny commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

huult commented Jul 9, 2026

Uh oh!

mountiny commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mountiny commented Jul 9, 2026 •

edited

Loading