Skip to content

fix(publish): add local-surface to the lockstep publish target list #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 1 commit into from
Jul 15, 2026
Merged

fix(publish): add local-surface to the lockstep publish target list #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,11 @@ jobs:
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# local-surface (→ deploy + persona-kit + runtime; consumed by cli)
# cli (→ persona-kit + workload-router + deploy + local-surface)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=events persona-kit runtime compose delivery workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"
echo "packages=events persona-kit runtime compose delivery workload-router deploy mcp-workforce daytona-runner local-surface cli agentworkforce" >> "$GITHUB_OUTPUT"
Comment on lines +98 to +102

@coderabbitai coderabbitai Bot Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep release-note ordering in sync with the publish target list.

local-surface is now published, but it is missing from packageOrder at Lines 713-723. Its indexOf result is therefore -1, so release notes place it before the other packages instead of between daytona-runner and cli.

 const packageOrder = [
   // ...
   'daytona-runner',
+  'local-surface',
   'cli',
   'agentworkforce',
 ];
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/publish.yml around lines 98 - 102, Update the packageOrder
definition in the release-note generation logic to include local-surface between
daytona-runner and cli, matching the publish target list and preserving the
intended release-note ordering.


# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand Down
Loading