Skip to content

fix(publish): add local-surface to the lockstep publish target list#271

Merged
khaliqgant merged 1 commit into
mainfrom
fix/publish-local-surface
Jul 15, 2026
Merged

fix(publish): add local-surface to the lockstep publish target list#271
khaliqgant merged 1 commit into
mainfrom
fix/publish-local-surface

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • @agentworkforce/local-surface (added in feat(local-surface): fleet-node bridge for running proactive personas on a laptop #263) was never added to the hardcoded package list in publish.yml's "Resolve target packages" step.
  • Because of that, it never went through the pnpm pack step that rewrites workspace:* deps to concrete versions before npm publish. It ended up on npm (v4.1.17, its only published version) with literal "workspace:*" strings still in its dependencies for @agentworkforce/deploy, persona-kit, and runtime.
  • Any plain npm install that resolves this package now hard-crashes with Unsupported URL Type "workspace:": workspace:* (npm-package-arg can't parse the pnpm workspace protocol). This breaks npm install -g agentworkforce@latest entirely, since @agentworkforce/cli depends on local-surface@4.1.17.
  • Fix: add local-surface to the topological package list, slotted after its workspace deps (deploy/persona-kit/runtime) and before its only consumer (cli).

Test plan

  • YAML validated (yaml.safe_load)
  • Next Publish Packages workflow run republishes local-surface at the new lockstep version via pnpm pack (confirms workspace refs are resolved in the published tarball)
  • npm install -g agentworkforce@latest succeeds after the new version is live

🤖 Generated with Claude Code

Review in cubic

@agentworkforce/local-surface was added in #263 but never added to the
hardcoded package list in publish.yml, so it never went through the
pnpm-pack step that rewrites workspace:* deps to concrete versions.
It was published to npm out-of-band (likely a manual `npm publish`),
leaving literal "workspace:*" strings in its published dependencies
(@agentworkforce/deploy, persona-kit, runtime). Any plain `npm install`
that resolves this package now crashes with "Unsupported URL Type
workspace:" — npm-package-arg can't parse the pnpm workspace protocol.

Slotting it into the topological list (after its deploy/persona-kit/
runtime deps, before its only consumer cli) lets the next publish run
correctly pack and republish it via `pnpm pack`, superseding the
broken 4.1.17.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@cursor

cursor Bot commented Jul 15, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The publish workflow now includes local-surface in the lockstep package set, affecting the workspaces built, versioned, packed, and published.

Changes

Publish workflow

Layer / File(s) Summary
Lockstep package resolution
.github/workflows/publish.yml
The dependency-order comment and resolved package output add local-surface between daytona-runner and cli.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: willwashburn, miyaontherelay, claude

Poem

I’m a bunny hopping through the flow,
Adding one package in the row.
local-surface joins the train,
Built and packed along the lane.
Publish softly, hop hooray!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: adding local-surface to the publish target list.
Description check ✅ Passed The description matches the change and explains the missing package plus the publishing fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-local-surface

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/publish.yml:
- Around line 98-102: Update the packageOrder definition in the release-note
generation logic to include local-surface between daytona-runner and cli,
matching the publish target list and preserving the intended release-note
ordering.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a61f190e-0576-45ce-bbe6-3bbd19c64b60

📥 Commits

Reviewing files that changed from the base of the PR and between 2acd56e and 8fd6bc7.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml

Comment on lines +98 to +102
# local-surface (→ deploy + persona-kit + runtime; consumed by cli)
# cli (→ persona-kit + workload-router + deploy + local-surface)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=events persona-kit runtime compose delivery workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"
echo "packages=events persona-kit runtime compose delivery workload-router deploy mcp-workforce daytona-runner local-surface cli agentworkforce" >> "$GITHUB_OUTPUT"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep release-note ordering in sync with the publish target list.

local-surface is now published, but it is missing from packageOrder at Lines 713-723. Its indexOf result is therefore -1, so release notes place it before the other packages instead of between daytona-runner and cli.

 const packageOrder = [
   // ...
   'daytona-runner',
+  'local-surface',
   'cli',
   'agentworkforce',
 ];
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/publish.yml around lines 98 - 102, Update the packageOrder
definition in the release-note generation logic to include local-surface between
daytona-runner and cli, matching the publish target list and preserving the
intended release-note ordering.

@khaliqgant
khaliqgant merged commit d091eb9 into main Jul 15, 2026
3 checks passed
@khaliqgant
khaliqgant deleted the fix/publish-local-surface branch July 15, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant