refactor: workspace.ts に getActiveTab helper を抽出 (#257)#258
Merged
Conversation
`state.tabs.find((t) => t.id === state.activeTabId)` パターンが navigateHistory / selectNavigation / navigateInTab の 3 箇所で 重複していたため、module-local helper `getActiveTab(state)` として 抽出。findIndex 系 (L77 / L285) や別配列 find (L291) は対象配列または 用途が異なるため対象外。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
src/stores/workspace.ts内でstate.tabs.find((t) => t.id === state.activeTabId)パターンが 3 箇所で重複していたため、module-local helpergetActiveTab(state: WorkspaceState): Tab | undefinedとして抽出。関連 Issue
closes #257
移行 Stage
(該当なし — store 内部の小規模 refactor)
変更内容
src/stores/workspace.tsに module-local helper を追加:function getActiveTab(state: WorkspaceState): Tab | undefinedstate.tabs.find((t) => t.id === state.activeTabId)をgetActiveTab(state)に置換:navigateHistory内selectNavigationselectornavigateInTab内activateTabByOffset/ L285closeTabsByPrefix) と別配列 find (L291) は対象配列または用途が異なるため scope 外動作確認
[](8 angle 全 (none)、Reuse 2 件 = L77/L285 findIndex 非対称は scope 外として skip)スクリーンショット
(該当なし — store 内部 refactor、UI 変更なし)