docs(7-bm): resolve FLOW-1 command-vs-read; name the continuous-regulation runtime gap#369
Open
xmap wants to merge 1 commit into
Open
docs(7-bm): resolve FLOW-1 command-vs-read; name the continuous-regulation runtime gap#369xmap wants to merge 1 commit into
xmap wants to merge 1 commit into
Conversation
…ation runtime gap The command-vs-read half of FLOW-1 is settled: CORA COMMANDS the regulated gas-flow / air setpoint (the FlowController presents the earned Regulator Role; a one-shot SetpointStep), not read-back-only. What stays open is split out and named precisely. A continuous setpoint PROGRAM, a hold or ramp held during a Run while the scan acquires, has no runtime today: the Conductor walks a finite step list and SetpointStep / ControlPort.write are one-shot. The regulation loop itself is correctly device/IOC-owned (the Sierra controller runs its own loop); CORA's gap is expressing and observing the program, not hosting the loop. This is the deepest cross-facility architectural gap the device audit named, and 7-BM (flow/combustion) is its grounding case alongside i11 / XPD thermal. It is deferred to a Stage-0 research note and a later gate-reviewed build, exactly as the event-stream axis was for XFEL/XPCS acquisition. FlowController stays loose (7-BM + I22, short of rule-of-three; not graduated). FLOW-1 stays live in questions.md / inventory.md for the two remaining parts (FlowController graduation + the setpoint-program runtime), so the test_open_questions_alignment guard keeps the question and its placeholders in step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves the command-vs-read half of 7-BM FLOW-1 and names the continuous-regulation runtime gap precisely. Docs/descriptor only; 7-BM stays a design-phase scaffold (no scenario, no spine code).
Why
The audit named continuous regulation (a setpoint held/ramped during a Run, orthogonal to the scan step-list) the deepest remaining cross-facility gap. This pass settles the part FLOW-1 actually blocks on and pins the rest:
FlowControllerpresents the earnedRegulatorRole; a one-shotSetpointStep, not read-back-only.SetpointStep/ControlPort.writeare one-shot and the Conductor walks a finite step list. The regulation loop itself stays device/IOC-owned (the Sierra controller runs it); CORA's gap is expressing and observing the program, not hosting the loop. Deferred to a Stage-0 research note + a later gate-reviewed build, exactly as the event-stream axis was for XFEL/XPCS acquisition.FlowControllerstays loose (7-BM + i22, short of rule-of-three).FLOW-1stays live inquestions.md/inventory.mdfor the two remaining parts (FlowController graduation + the setpoint-program runtime).Files
deployments/7-bm/beamline.yaml- FlowController notedocs/deployments/7-bm/{model,questions,inventory}.mdVerification
pytest tests/unit/deployments/- 275 passed (incl.test_open_questions_alignment)make docs-build- cleanNo new Family / Role / Method / kind (no naming-r3 needed);
Regulatoralready exists,FlowControllerstays loose.🤖 Generated with Claude Code