feat: add hybrid localization system (hardcoded + external JSON)#170
Open
gridgt wants to merge 1 commit into
Open
feat: add hybrid localization system (hardcoded + external JSON)#170gridgt wants to merge 1 commit into
gridgt wants to merge 1 commit into
Conversation
gridgt
force-pushed
the
feature/external-localization
branch
2 times, most recently
from
78a61ef to
a7f44f8
Compare
- scanLangDir() discovers lang/*.json at startup, adds new languages - loadExternal() merges JSON translations over hardcoded dictionaries - Encoding: UTF-16 LE with BOM via Util::readFile (same as config.json) - de-DE.json included as external-only test language
gridgt
force-pushed
the
feature/external-localization
branch
from
a7f44f8 to
0d6cc1a
Compare
Owner
|
The current multilingual support module isn’t well-designed yet. I’ll take a closer look and review your PR before merging it. Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hybrid Localization System
Built-in dictionaries remain as the primary translations. External JSON files in the
lang/folder can:No code changes needed to add a new language or fix a translation. Just place
xx-XX.jsonin thelang/folder next to the executable and restart.de-DE.json(Deutsch) is included as an external-only test.