fix: restrict remote skill sources to GitHub - #855
Open
failsafesecurity wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Owner
|
Thank you for pointing out this issue. However, the Skills we support are not limited to GitHub repositories. For example, ModelScope Skills can use URLs such as https://modelscope.cn/skills/@pskoett/self-improving-agent. Therefore, restricting the source validation to GitHub repositories only would reject valid Skill sources. Could we broaden the validation to support other legitimate Skill formats while still preventing requests to localhost, private networks, and other internal endpoints? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This restricts remote skill imports to GitHub shorthand or canonical GitHub HTTPS URLs before the backend invokes the
skillsCLI.Security impact
Before this patch, any authenticated user could call the remote-skill import endpoints with an arbitrary
sourcevalue. The backend passed that value straight intonpx skills add <source>, which let a regular user trigger server-side clone/fetch requests to localhost, RFC1918 addresses, cloud metadata endpoints, or other internal HTTP(S) services reachable from the Yuxi host.Changes
sourcebefore invoking the remote skills CLIOWNER/REPOshorthand or canonicalhttps://github.com/OWNER/REPO(.git)URLsfile://, SSH, and query-string variantsValidation
npx -y skills add http://127.0.0.1:9/repo.git --list, which attempted a backend-side clone to loopbackpython3 -m py_compilepytest/uvare not installed hereDisclosure notes
SECURITY.mdis present in the repo root