Add checking in SHE response handlers#391
Open
padelsbach wants to merge 2 commits into
Open
Conversation
padelsbach
commented
May 29, 2026
|
|
||
| resp = (whMessageShe_SetUidResponse*)wh_CommClient_GetDataPtr(c->comm); | ||
| ret = wh_Client_RecvResponse(c, &group, &action, &dataSz, (uint8_t*)resp); | ||
| if (ret == WH_ERROR_OK) { |
Contributor
Author
There was a problem hiding this comment.
Could macro'ize this, but not sure if that's more readable
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #391
Scan targets checked: wolfhsm-core-bugs, wolfhsm-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
padelsbach
force-pushed
the
she-response-checking
branch
from
d367077 to
8616f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for group, action and len in SHE response handlers. Found with experimental fuzzing.