Skip to content

fix: OngoingCallActivity metro injection [WPB-8645]#4935

Merged
saleniuk merged 1 commit into
developfrom
fix/ongoingcallactivity_metro_injection
Jun 5, 2026
Merged

fix: OngoingCallActivity metro injection [WPB-8645]#4935
saleniuk merged 1 commit into
developfrom
fix/ongoingcallactivity_metro_injection

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented Jun 5, 2026

https://wearezeta.atlassian.net/browse/WPB-8645


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Answering a call from notification crashes.

Causes (Optional)

Things are not being properly injected into OngoingCallActivity.

Solutions

Add OngoingCallActivity to WireApplicationGraph and call inject.

How to Test

Open the app, receive incoming call, answer from notification.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.32%. Comparing base (691dade) to head (acdf63f).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4935      +/-   ##
===========================================
+ Coverage    49.30%   49.32%   +0.01%     
===========================================
  Files          646      646              
  Lines        22874    22891      +17     
  Branches      3503     3503              
===========================================
+ Hits         11279    11291      +12     
- Misses       10549    10553       +4     
- Partials      1046     1047       +1     
Files with missing lines Coverage Δ
.../android/ui/calling/ongoing/OngoingCallActivity.kt 29.41% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691dade...acdf63f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saleniuk saleniuk added this pull request to the merge queue Jun 5, 2026
Merged via the queue into develop with commit 9bfd96d Jun 5, 2026
21 checks passed
@saleniuk saleniuk deleted the fix/ongoingcallactivity_metro_injection branch June 5, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants