fix(tooling): migrate to use github-actions#1467
Open
Shreyas281299 wants to merge 15 commits into
Open
Conversation
Extract dependency artifacts at repository root and use npm run argument forwarding for the build step so integration build jobs can resolve binaries reliably in GitHub Actions. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace artifact-based node_modules transfer with actions/cache save/restore so binaries in .bin remain executable across jobs and lint/build steps can resolve CLI tools. Co-authored-by: Cursor <cursoragent@cursor.com>
Add workflow_dispatch mode input and gate all publishing side effects behind release mode so forks can validate deploy build logic without pushing tags, publishing npm packages, or writing to AWS. Co-authored-by: Cursor <cursoragent@cursor.com>
Mark Chrome and Firefox journey jobs as non-blocking and cap each integration test step at 5 minutes to keep PR feedback responsive. Co-authored-by: Cursor <cursoragent@cursor.com>
Separate mode resolution, npm publish, CDN deploy, and dry-run build into dedicated jobs so fork testing is safer and release side effects are isolated. Co-authored-by: Cursor <cursoragent@cursor.com>
Restructure deploy workflow into separate npm and CDN build/publish jobs, keep fork-safe dry-run mode, and route npm publishing through publish:components without duplicate standalone npm build steps. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove NODE_ENV=production from the prepare job so npm ci caches full dependencies required by downstream build and release tooling. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the no-op build_npm stage and have publish_npm depend directly on prepare while keeping release-mode gating intact. Co-authored-by: Cursor <cursoragent@cursor.com>
Move commit/tag push to run after publish:components so git refs are updated only when npm publish succeeds. Co-authored-by: Cursor <cursoragent@cursor.com>
Finalize deploy workflow for master push releases by removing workflow_dispatch dry-run mode and related conditional test scaffolding. Co-authored-by: Cursor <cursoragent@cursor.com>
Delete the stale pipeline migration guide now that workflow behavior has been consolidated directly in the deploy and pull-request workflows. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Shreyas281299
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-818673
This pull request addresses
Migrating CI/CD from CircleCI to GitHub Actions while removing temporary fork-testing behavior and ensuring release-side effects are ordered safely.
by making the following changes
.github/workflows/pull-request.ymlwith validated-label gating, cached dependency reuse, and restored strict integration test behavior..github/workflows/deploy.ymlto run on pushes tomaster, split CDN build/publish concerns, and enforce pushing release commit/tags only after successful npm publish..github/pipeline-guide.mddocument.Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging