Fix cache key collisions, HTTP scheme mixing, and Vary ambiguity#73
Merged
Conversation
Adopt scheme-aware URL keys, SHA-1 fragment digests, clearer Vary delimiters, compiled key rules with sync fast path, and a tightened public export surface.
🦋 Changeset detectedLatest commit: f6926f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a major release that overhauls cache key generation to fix correctness and HTTP alignment issues:
httpandhttpsfrom sharing the same entry — URL scheme is included in default keys (RFC 9111 URI identity).|v|/|vary|suffixes so base keys, Vary metadata, and variants cannot be parsed incorrectly.#cookie:a|header:x-id@…); only normalized values are digested.match()/delete()supportignoreMethodonly; ignore query strings viacacheKeyRules.search: false, bypass Vary viasharedCache.ignoreVary.Also includes compiled cache-key rules with a sync fast path, per-request header/cookie context sharing, tightened public exports, and expanded test coverage (~98.8% statements).
Breaking changes
https://…); setscheme: falsefor the previous host-first shape.cacheKeyPartDefiners/SharedCacheKeyPartDefiners; use built-incacheKeyRulesonly.Test plan
pnpm test(331 tests, ~98.8% statement coverage)scheme: falseif needed