fix: cache revalidation, UPDATING status, and x-cache-key encoding#70
Merged
Conversation
Fix 304 background revalidation persistence so subsequent requests return fresh HIT, add UPDATING for stale-while-revalidate, return 304 from match for conditional requests, and percent-encode x-cache-key values.
🦋 Changeset detectedLatest commit: 2830219 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Use STALE for stale-if-error on origin errors, omit body headers on conditional 304 responses, rename cachedBody to storedBody, and add tests for conditional match edge cases and non-storable revalidation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revalidatedPolicydirectly instead of rebuilding from stale response headers, so the next request returns freshHITwithAge: 0UPDATINGcache status forstale-while-revalidate(Cloudflare CDN alignment); reserveSTALEforstale-if-error304 Not ModifiedfromCache.match()whenIf-None-Match/If-Modified-Sincematch a fresh cached entryx-cache-keyheader values so cache keys with control characters or non-Latin-1 Unicode are valid HTTP header field valuesAgefrom stored policy metadata on read for compatibility with legacy entriesTest plan
npm test(272 tests passed)