adds validation and milestones, adds checkstyle and pmd for jdk 11#5
Open
awhicks wants to merge 1 commit into
Open
adds validation and milestones, adds checkstyle and pmd for jdk 11#5awhicks wants to merge 1 commit into
awhicks wants to merge 1 commit into
Conversation
Signed-off-by: Alex Hicks <awh4kc@vt.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation - support for test case validation (and fixed bugs related to the ability to turn it off) - I had forgotten that I had already done some intercepting of the junit messages for the validation specific warnings, so the updates to expected/actual should be pretty simple
Milestones - adds support for three milestones with multiple requirements as used by 3114 - the config options are in their own section in the config - this required a couple of perl plugins that were included in this PR - TODO: save all history in hashes in properties to facilitate regrading
Checkstyle and PMD - added support for new versions of checkstyle and pmd that depend on java 11 - PMD is still in progress, but the structure exists (https://github.com/web-cat/web-cat-docker-plugin-JavaTddPlugin/tree/main/plugins/checkstyle-10.7.0 and https://github.com/web-cat/web-cat-docker-plugin-JavaTddPlugin/tree/main/plugins/pmd-7.21.0 need installed)
JavaTddPlugin - Off the top of my head, the test coverage goal was moved out of the reusable config options into the assignment specific ones