feat(dggs): consolidate decoders into one module - #59
Open
ibgreen-openai wants to merge 2 commits into
Open
Conversation
ibgreen-openai
changed the title
ibgreen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@math.gl/dggs-geohash,@math.gl/dggs-quadkey, and@math.gl/dggs-s2packages with one@math.gl/dggspackage.GeohashDecoder,QuadkeyDecoder, andS2Decoderobjects that implement the sharedDGGSDecoderAPI.@math.gl/expressionsto the consolidated package and preserve its existing DGGS function-library names.Review focus
feat(dggs): consolidate decoders into one module— package/source migration, expressions integration, lockfile, and decoder tests.docs(dggs): document consolidated decoder API— documentation moves, API reference, and upgrade guidance.Most of the file count is package/document relocation. The functional changes are concentrated in the decoder objects, S2 Hilbert conversion, and expressions adapter.
Split decision
Kept as one PR because package removal, replacement exports, consumer migration, and lockfile updates must land atomically. The history is split into implementation and documentation commits for review.
Validation
yarn lintyarn test node: 2,765 passingyarn test browser-headless: 2,765 passingyarn build