fix(vidstack): load CDN externals from jsDelivr#1820
Merged
Conversation
mihar-22
force-pushed
the
codex/1774-1640-cdn-externals
branch
from
8d1783d to
b09d637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media-icons,media-icons/element, andmedia-captionsdirectly to jsDelivr package URLs.https://cdn.jsdelivr.net/npm/media-icons@1.1.5/dist/lazy.js/+esmformedia-icons./+esmto every jsDelivr CDN external path.cdn.vidstack.io, which avoids the invalid captions parser paths reported for SRT tracks.Fixes #1774.
Fixes #1640.
#1638 is duplicate/covered by the CDN external URL fix.
Validation
pnpm --filter vidstack typecheckpnpm exec oxfmt --check packages/vidstack/tsdown.config.tspnpm --filter vidstack build:cdndist-cdn: jsDelivr externals use/+esm,media-iconsno longer usesdist/index.js, and nocdn.vidstack.io,@next, or non-/+esmexternal forms remain.