app-16292: small component tweaks to support per-entity pose mutators

[DTCurrie]

Small entity-rendering, raycasting, and UI primitive changes that unblock the Gizmos plugin in #738.

Note

Use this PR preview to view all of the changes from this stack: https://viamrobotics.github.io/visualization/pr-preview/pr-739/snapshot

Stack

1. Shared ECS traits and helpers (app-16292: shared ECS traits and helpers for entity pose plugins #735)
2. Details refactor (app-16292: refactor Details panel into focused subcomponents #736)
3. This PR: Component tweaks
4. Gizmos plugin (app-16292: add Gizmos plugin #738)
5. Gizmos plugin docs (app-16292: add docs page for the Gizmos plugin #739)

Frontend

• src/lib/components/Entities/LineDots.svelte: tracks the instance IDs returned by addInstance per effect run instead of assuming a sequential 0..N-1 range. Fixes Invalid instanceId errors when positions changes between runs.
• src/lib/components/Scene.svelte: enables BVH raycasting when settings.interactionMode === 'gizmo', matching the existing 'measure' and 'select' branches.
• src/lib/components/SelectedTransformControls.svelte: reads ref.position and ref.quaternion directly instead of getWorldPosition / getWorldQuaternion. Frame-style renderers set matrixAutoUpdate = false and re-compose their local matrix from worldMatrix on every flush, so the world getters were returning the pre-drag transform and the entity Matrix trait never updated.
• src/lib/components/overlay/Popover.svelte: extends the trigger snippet signature with { isOpen } and the children snippet with { close } so consumers can reflect open state in their trigger and dismiss the popover programmatically.
• src/lib/components/overlay/dashboard/Button.svelte: adds the shapes (lucide) icon and a disableTooltip prop for buttons whose persistent active state already conveys what the tool is.

Testing

Ran pnpm check and pnpm test. Drag-rotated a frame entity with TransformControls in the dev app to confirm the SelectedTransformControls change actually mutates the entity Matrix after the fix.

[changeset-bot]

🦋 Changeset detected

Latest commit: f376b4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@viamrobotics/motion-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[DTCurrie]

@claude final review

[claude]

Claude finished @DTCurrie's task in 2m 45s —— View job

---

Final Review

• Gather context — reading changed files and diff
• Review each changed file
• Check Popover snippet compatibility with existing callers
• Verify interactionMode type includes 'gizmo'
• Summarize findings

---

Overall: this is ready to merge. All five logic changes are correct, the comments are accurate and appropriately detailed for non-obvious invariants, and the tests adequately cover the new disableTooltip prop. No blocking issues found.

Per-file notes

LineDots.svelte — fix is clean and the approach is correct. The instances array is only populated (and the cleanup closure only registered) when positions is truthy, so the early-return guard on cleanup is no longer needed. The closure captures instances by reference so it sees the fully-populated array at cleanup time. No issues.

Scene.svelte — 'gizmo' is already a valid interactionMode literal in useSettings.svelte.ts:10, so the addition is type-safe. Simple, correct.

SelectedTransformControls.svelte — fix is correct. The matrixToPose → vector3ToPose/quaternionToPose two-step correctly preserves the unchanged component (rotation when translating, position when rotating). The removed ref.quaternion.copy(quaternion) was a redundant workaround artifact. The NOTE: block directly in the comment addresses the prior review concern about the flat-hierarchy assumption. The unused Quaternion and Vector3 imports are correctly pruned.

Popover.svelte — the API extension is backwards-compatible. Existing callers (MeasureTool.svelte, SelectionTool.svelte) destructure only triggerProps from the trigger snippet and pass implicit children content — TypeScript allows a function with fewer declared parameters to satisfy a function type with more (parameter list is covariant in cardinality), so svelte-check will not flag these callers. Confirmed: pnpm check output shows no new errors in those files, only the pre-existing missing proto-generated-file errors unrelated to this PR.

Button.svelte — state={disableTooltip ? 'invisible' : undefined} is the idiomatic prime-core Tooltip API for suppressing the tooltip. Shapes import and icon branch are straightforward. The JSDoc is clear.

Button.svelte.spec.ts — both new cases correctly assert that disableTooltip and active are orthogonal. Tests follow the existing pattern exactly.

Minor nit (non-blocking)

In Popover.svelte, close could optionally be $derived so it stays referentially stable if api ever changes identity:

const close = $derived(() => api.setOpen(false))

In practice this doesn't matter since the close callback only reads api at call time (not at closure time), but it would match the reactive pattern used for api itself. Not worth a round-trip change.