feat: support channel filtering in SDF - #23
Open
upils wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
channelfield to slice definition files, so a single SDF can describe content that differs across the channels of a store package. Values are<track>/<risk>patterns where the risk part accepts*(any risk),!<risk>(any but that one) and<risk>,<risk>(only those); a list of values is a union, and a track may appear at most once. It is accepted oncontentspaths and onessentialentries, requiresstoreand format v3+, and behaves throughout likearch: non-matching entries are silently skipped, conflict validation and the manifest ignore it.Patterns are kept as written in
[]stringand interpreted on each match — the structure strdist uses for globs — and validated when the release is read, so malformed values fail onReadReleaserather than oncut. Filtering happens at the three placesarchalready filters: the two content loops inslicer.Runand the essential traversal inorder, where the gate uses the channel of the package holding the essential.channelis only legal on store packages, and store fetching still returnsnot implemented, so those two lines are unreachable from a test. Parse and select layers are covered. If the store fetching lands before this PR, tests must be added.