Fix: AsyncWebCrawler blocks event loop with scrap, use ascrap instead.#1986
Open
jtgi wants to merge 1 commit into
Open
Fix: AsyncWebCrawler blocks event loop with scrap, use ascrap instead.#1986jtgi wants to merge 1 commit into
scrap, use ascrap instead.#1986jtgi wants to merge 1 commit into
Conversation
aprocess_html() was calling the synchronous scrap() method directly on the event loop, blocking it during lxml DOM parsing and HTML processing. All ContentScrapingStrategy subclasses already implement ascrap() via asyncio.to_thread(). Switch to using it.
jtgi
changed the title
scrap, use ascrap instead.
jtgi
changed the title
scrap, use ascrap instead.scrap, use ascrap instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncWebCrawler.arun()uses synchronous scraping (scrap) which blocks the event loop. It should use asynchronousascrap.Discovered during production capacity issue.
Testing