Skip to content

Convert numerics vars to dataclass#4306

Merged
timothy-nunn merged 4 commits into
mainfrom
Numerics-Vars_Dataclass
Jun 18, 2026
Merged

Convert numerics vars to dataclass#4306
timothy-nunn merged 4 commits into
mainfrom
Numerics-Vars_Dataclass

Conversation

@clmould

@clmould clmould commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.93220% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.79%. Comparing base (5bc1887) to head (82c02e8).

Files with missing lines Patch % Lines
process/core/scan.py 0.00% 33 Missing ⚠️
process/core/solver/solver_handler.py 0.00% 17 Missing ⚠️
process/core/solver/solver.py 8.33% 11 Missing ⚠️
process/core/final.py 0.00% 6 Missing ⚠️
process/core/solver/iteration_variables.py 66.66% 6 Missing ⚠️
process/core/caller.py 0.00% 4 Missing ⚠️
process/core/io/vary_run/config.py 0.00% 4 Missing ⚠️
process/core/solver/evaluators.py 0.00% 4 Missing ⚠️
process/models/physics/physics.py 0.00% 4 Missing ⚠️
process/core/io/vary_run/tools.py 40.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4306      +/-   ##
==========================================
- Coverage   48.89%   48.79%   -0.11%     
==========================================
  Files         151      151              
  Lines       29439    29383      -56     
==========================================
- Hits        14395    14337      -58     
- Misses      15044    15046       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould mentioned this pull request Jun 12, 2026
74 tasks
@clmould clmould force-pushed the Numerics-Vars_Dataclass branch 2 times, most recently from 4dd9ca6 to 004de62 Compare June 16, 2026 12:47
@clmould clmould marked this pull request as ready for review June 16, 2026 12:55
@clmould clmould requested a review from a team as a code owner June 16, 2026 12:55
Comment thread process/core/io/plot/solutions.py
Comment thread process/core/solver/solver.py Outdated
Comment thread process/core/solver/solver.py Outdated
@clmould clmould force-pushed the Numerics-Vars_Dataclass branch from 745d23a to 0ed8dbe Compare June 18, 2026 10:20
@clmould clmould requested a review from timothy-nunn June 18, 2026 10:21
@clmould clmould force-pushed the Numerics-Vars_Dataclass branch from 0ed8dbe to 82c02e8 Compare June 18, 2026 10:22
@clmould clmould added the Data structure Issues related to the data structure label Jun 18, 2026
@timothy-nunn timothy-nunn merged commit 89e1ebe into main Jun 18, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the Numerics-Vars_Dataclass branch June 18, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants