Update some constraints vars#4299
Open
chris-ashe wants to merge 23 commits into
Open
Conversation
a242795 to
68421ee
Compare
1cadd90 to
b8076fd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4299 +/- ##
==========================================
+ Coverage 48.86% 48.89% +0.02%
==========================================
Files 151 151
Lines 29461 29448 -13
==========================================
+ Hits 14397 14399 +2
+ Misses 15064 15049 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b6ba8ee to
5a5463b
Compare
…iles for consistency
…nsistency across the codebase
…ency in physics and constraint data structures
…r improved accuracy
…tants.TEMP_ROOM for consistency
…ency across the codebase
…stency across the codebase
…and consistency; update related references in constraints and input files.
…stency; update related references in constraints, cost variables, and input files.
… for clarity and consistency; update related references across multiple files.
…ent_min` for clarity and consistency; update all related references across multiple files.
…ity and consistency; update all related references across multiple files.
… and consistency; update all related references across multiple files.
…rove docstring for p_div_bt_q_aspect_rmajor_mw
…eferences across multiple files
…cy; update all related references across multiple files.
- Updated docstrings for clarity, including detailed descriptions of parameters and return values. - Refactored power calculations in the PlasmaExhaust class to use a new method for radiation fraction calculation.
… for improved calculations
f8b768b to
611674f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on standardizing and updating variable names across the codebase and input files for improved clarity and consistency, especially for constraint and physics-related parameters. It also updates documentation to reflect these new names and ensures all example input files use the revised identifiers.
Variable Renaming and Consistency
process/core/input.pyand all example input files to use clearer, more descriptive identifiers for key constraints and physics parameters, such as:fdene→f_nd_plasma_electron_limit_maxfiooic→f_j_tf_wp_critical_maxpsepbqarmax→p_div_bt_q_aspect_rmajor_max_mwnflutfmax→flu_tf_neutron_fast_maxf_alpha_energy_confinement_min→f_t_alpha_energy_confinement_minzeff_max→n_charge_plasma_effective_vol_avg_maxaplasmin->rminor_minavail_min->f_t_plant_available_minfradpwr->f_p_plasma_seperatrix_rad_maxpseprmax->p_plasma_separatrix_rmajor_max_mwDocumentation Updates
Example Input File Modernization
Minor Improvements
These changes collectively improve the maintainability and clarity of the codebase by enforcing consistent naming conventions and ensuring that documentation and examples are up to date.
Checklist
I confirm that I have completed the following checks: