This repository was archived by the owner on Aug 7, 2022. It is now read-only.
fix: KV Namespace list method accepts an object#32
Open
13rac1 wants to merge 3 commits into
Open
Conversation
richardkalehoff
approved these changes
Jun 7, 2021
richardkalehoff
left a comment
richardkalehoff
left a comment
Member
There was a problem hiding this comment.
A couple of minor suggestions, but this looks good to me 👍🏻
Co-authored-by: Richard Kalehoff <richardkalehoff@gmail.com>
Co-authored-by: Richard Kalehoff <richardkalehoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
KV.list()method signature according to the docs is:This solution seems correct to resolve #27 but I'm not 100% about it. Open to better ideas??? @adamjakab @marcelduin