[pull] master from php:master#1040
Merged
Merged
Conversation
…max_size values
…t_max_size values 998bce0 is accidentally pushed directly to master as this should go to a PR branch. This commit revert that.
The HAVE_LIBINTL macro is defined only when the ext/gettext is enabled during the build. Also, LC_MESSAGES have been moved to other places since this header was initially included.
spl_recursive_it_move_forward_ex() tears down the exhausted level after running its sub-iterator, but endChildren() and a sub-iterator's valid() can re-enter through $this->next() and tear that level down first. The no-more-elements branch then dtored a stale iterator pointer, and valid() kept running on a sub-iterator the reentrant call had already freed. Guard the teardown on the level's iterator being unchanged, and hold a reference on the sub-iterator across valid(). Closes GH-22478
* PHP-8.4: Fix use-after-free in RecursiveIteratorIterator on reentrant teardown
* PHP-8.5: Fix use-after-free in RecursiveIteratorIterator on reentrant teardown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )