Move sig verification from installer to resolver#257
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves package signature verification from the installer phase into the dependency resolution phase so manifests (including dependency sets) are verified as they’re fetched/resolved, aligning with the updated registry signing behavior.
Changes:
- Introduce a
signatures.Verifierthat builds a canonical signing payload including a dependencies digest. - Fetch signing keys and verify manifest signatures inside the resolver’s metadata fetch flow.
- Remove installer-time signature verification and signature propagation in install actions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/pm/signatures/signatures.go | Adds verifier + canonical payload/deps digest logic for signature verification. |
| pkg/pm/signatures/signatures_test.go | Adds unit tests for canonical dependency serialization and payload construction. |
| pkg/pm/resolution/resolver.go | Fetches keys and verifies package signatures during resolution; improves request dedupe keying. |
| pkg/pm/registry/client.go | Updates GetKeysJson to return the new signatures.Keys type. |
| pkg/pm/installer/plan.go | Drops signatures from install actions (verification no longer happens in installer). |
| pkg/pm/installer/installer.go | Removes key fetching and signature verification from install/update path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry now signs a package dependencies as well which needs to be verified while resolving the packages. This PR moves the signatures verification from installer to resolver.
More information about signatures spec can be found in
pkg/pm/signatures/signatures.go.