fix(ci): upgrade actions/cache to v5 and fix container git checkout#6808
fix(ci): upgrade actions/cache to v5 and fix container git checkout#6808317787106 wants to merge 4 commits into
Conversation
bladehan1
left a comment
There was a problem hiding this comment.
Automated review by AI pipeline (see .review-system/tasks/PR6808 for full artifacts).
Decision: Approve
Findings: P0=0, P1=0, P2=1, nit=1
NOTE: This review was generated by Claude Code's /review pipeline. Comments are AI suggestions; human reviewers retain final judgment.
| java -jar "$JAR" db --help | ||
| java -jar "$JAR" db archive -h | ||
| java -jar "$JAR" keystore --help | ||
|
|
There was a problem hiding this comment.
[NIT] build-ubuntu disable strategy — 2 small follow-ups
Both items relate to the commented-out build-ubuntu job:
-
"deprecate" vs "temporarily disable" in PR title/commit. The PR title says "deprecate ubuntu 24 + aarch64", but the description says "re-enable once the runner stabilizes" — these are contradictory. "Deprecate" implies a planned phase-out with a notice period; what's happening here is a temporary workaround for an upstream runner instability. The PR title will land in git log and any generated changelog. Consider amending the commit subject to something like:
fix(ci): update action cache to v5; temporarily disable ubuntu-24.04-arm build -
No tracking reference in the comment block. The commented-out job has no link back to the upstream issue that caused the disable. Without it, there's no automated way to discover this when the runner stabilises. Consider adding a line above the block:
# TODO: Re-enable once actions/runner-images#14100 is resolved
Suggestion: Amend the commit/PR title to say "temporarily disable" instead of "deprecate", and add a TODO comment with the upstream issue reference above the commented block.
There was a problem hiding this comment.
ubuntu-24.04-arm appears to have become available today, so it is likely to continue working.
There was a problem hiding this comment.
ubuntu-24.04-arm has been uncomment and keep it stay.
What does this PR do?
actions/cachefromv4tov5inpr-build.yml,pr-check.yml, andsystem-test.yml(7 occurrences) to resolve the Node.js 20 deprecation warning on GitHub Actions runners.pr-build.yml(docker-build-rockylinux,docker-build-debian11,coverage-base) so the dependency-install step runs beforeactions/checkout. This ensuresgit(and the other build tools) are on thePATHat checkout time, so the action performs a realgit cloneinstead of falling back to the GitHub REST API.Why are these changes required?
actions/cache@v4uses Node.js 20; upgrading tov5moves it to Node.js 24 and eliminates the deprecation warning.rockylinux:8,eclipse-temurin:8-jdk) ship withoutgit. Because the install step previously ran afteractions/checkout, the action could not findgiton thePATHand emitted the warning "The repository will be downloaded using the GitHub REST API / To create a local Git repository instead, add Git 2.18 or higher to the PATH", checking out the source without a.gitdirectory. Installing the dependencies first removes the warning and yields a proper local Git repository.This PR has been tested by:
Follow up
Re-enable
build-ubuntuonceubuntu-24.04-armrunner stability is confirmed.