Feature/config manager pull custom nodes#98
Open
dallinjsevy wants to merge 1 commit into
Open
Conversation
dallinjsevy
force-pushed
the
feature/config-manager-pull-custom-nodes
branch
from
f0a1cde to
5c16f81
Compare
phalestrivir
requested changes
Jul 10, 2026
|
|
||
| export default function setup() { | ||
| const program = new FrodoCommand( | ||
| 'frodo config-manager pull custom-nodes', |
Comment on lines
+70
to
+71
| const { stdout } = await exec(CMD, forgeopsEnv); | ||
| expect(removeAnsiEscapeCodes(stdout)).toMatchSnapshot(); |
There was a problem hiding this comment.
Suggestion: I would replace these lines in your test code to be:
await testSuccess(CMD, forgeopsENV);This helper I created just helps simplify the testing code some more
dallinjsevy
force-pushed
the
feature/config-manager-pull-custom-nodes
branch
from
5c16f81 to
7f2fc64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.