feat: Add config-manager pull iga-workflows command by dallinjsevy · Pull Request #102 · trivir/frodo-cli

dallinjsevy · 2026-04-28T19:51:25Z

No description provided.

phalestrivir · 2026-07-10T17:03:20Z

+const { CLOUD_DEPLOYMENT_TYPE_KEY, FORGEOPS_DEPLOYMENT_TYPE_KEY } =
+  frodo.utils.constants;
+const deploymentTypes = [
+  CLOUD_DEPLOYMENT_TYPE_KEY,
+  FORGEOPS_DEPLOYMENT_TYPE_KEY,
+];


Forgeops is not a supported deployment for IGA, only Cloud, so remove Forgeops from this.

phalestrivir · 2026-07-10T17:04:31Z

+      if (options.realm) {
+        realm = options.realm;
+      }


Workflows are global configuration, not realm specific, so remove this

phalestrivir · 2026-07-10T17:05:21Z

+      if (await getTokens(false, true, deploymentTypes)) {
+        verboseMessage('Exporting config entity iga-workflows');
+        const outcome = await configManagerExportIgaWorkflows(
+          options.name,
+          options.includeImmutable
+        );
+        if (!outcome) process.exitCode = 1;
+      }
+    });


Change this code to look something like this:

frodo-cli/src/cli/config-manager/config-manager-push/config-manager-push-email-provider.ts

Lines 35 to 43 in 2c9d195

const getTokensIsSuccessful = await getTokens(

false,

true,

deploymentTypes

);

if (!getTokensIsSuccessful) process.exit(1);

verboseMessage('Importing email provider configuration.');

const outcome = await configManagerImportEmailProvider();

if (!outcome) process.exitCode = 1;

This is almost correct, although we need to make sure we are setting the exit code to 1 in the event that getTokens fails, which this example does.

phalestrivir · 2026-07-10T17:06:16Z

+        realm = options.realm;
+      }
+      if (await getTokens(false, true, deploymentTypes)) {
+        verboseMessage('Exporting config entity iga-workflows');


I would reword this message to be "Exporting IGA workflows...", since config entity is typically associated with IDM entities.

phalestrivir · 2026-07-10T18:31:26Z

+    let workflows = await readWorkflows();
+    if (name) {
+      workflows = workflows.filter((workflow) => workflow.name === name);
+    }
+    if (!includeImmutable) {
+      workflows = workflows.filter((workflow) => workflow.mutable);
+    }
+    workflows.forEach((workflow) => {
+      processIgaWorkflow(workflow, 'iga/workflows');
+    });


You can simplify this to be:

(await readWorkflows()) .filter(w => (!name || w.name === name) && (includeImmutable || !w.mutable)) .forEach(processIgaWorkflow);

For processIgaWorkflow you will need to modify it to no longer receive the fileDir, which is fine since there's no reason to pass it in as a parameter since it's a constant.

phalestrivir · 2026-07-13T16:12:34Z

+  try {
+    const workflowName = safeFileName(workflow.name);
+    const workflowPath = `${fileDir}/${workflowName}`;
+    if (Array.isArray(workflow.steps)) {


This check isn't necessary (steps will always be an array, even if there are no steps in the workflow)

phalestrivir · 2026-07-13T16:14:57Z

+          stepBody &&
+          typeof stepBody === 'object' &&
+          typeof stepBody.script === 'string' &&
+          stepBody.script.length > 0


You can simplify stepBody.script.length > 0 to just stepBody.script, since strings are falsy if they are empty.

phalestrivir · 2026-07-13T16:16:09Z

+const CMD = 'frodo config-manager pull iga-workflows --help';
+const { stdout } = await exec(CMD);
+
+test("CLI help interface for 'config export' should be expected english", async () => {


'config export' should be config-manager pull iga-workflows

phalestrivir · 2026-07-13T16:21:01Z

+/*
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-trivir-fairfax.forgeblocks.com/am frodo config-manager pull iga-workflows -D igaTestDir01
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-trivir-fairfax.forgeblocks.com/am frodo config-manager pull iga-workflows -n test_workflow_4 -D igaTestDir02
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-trivir-fairfax.forgeblocks.com/am frodo config-manager pull iga-workflows -i -D igaTestDir03


Add another two tests

With -i and -n together and try to export a non-mutable workflow (it should work)

With only -n like in test 2 (you will need to use --name to differentiate from that test), and try to export a non-mutable workflow. It should fail indicating that the workflow was not found (fr-config-manager's wording is specifically Workflow BasicApplicationGrant not found). For this test, I would use the helper that I created like await testFail(CMD, env); to test that the command fails.

phalestrivir · 2026-07-13T16:33:16Z

+      if (options.realm) {
+        realm = options.realm;
+      }
+      if (await getTokens(false, true, deploymentTypes)) {


Before getTokens, I would add an if-statement checking if the tenant is an IGA tenant, and fail early if not, as I did for the Frodo workflow commands:

frodo-cli/src/cli/iga/config/iga-config-export.ts

Lines 92 to 99 in ccab984

if (!state.getIsIGA()) {

printMessage(

'Command not supported for non-IGA cloud tenants',

'error'

);

process.exitCode = 1;

return;

}

phalestrivir · 2026-07-13T16:36:02Z

+  return false;
+}
+
+async function processIgaWorkflow(workflow, fileDir) {


Add a function comment to this. I would also rename it to processIgaWorkflowForExport to help differentiate it since there is also a function for processing a workflow for import in your push PR.

feat: Add config-manager pull iga-workflows command

1383e28

dallinjsevy requested a review from phalestrivir April 28, 2026 19:51

phalestrivir requested changes Jul 13, 2026

View reviewed changes

phalestrivir reviewed Jul 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add config-manager pull iga-workflows command#102

feat: Add config-manager pull iga-workflows command#102
dallinjsevy wants to merge 1 commit into
mainfrom
feature/config-manager-pull-iga-workflows

dallinjsevy commented Apr 28, 2026

Uh oh!

phalestrivir Jul 10, 2026

Uh oh!

phalestrivir Jul 10, 2026

Uh oh!

phalestrivir Jul 10, 2026

Uh oh!

phalestrivir Jul 10, 2026

Uh oh!

phalestrivir Jul 10, 2026

Uh oh!

phalestrivir Jul 13, 2026

Uh oh!

phalestrivir Jul 13, 2026

Uh oh!

phalestrivir Jul 13, 2026

Uh oh!

phalestrivir Jul 13, 2026

Uh oh!

phalestrivir Jul 13, 2026

Uh oh!

phalestrivir Jul 13, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const getTokensIsSuccessful = await getTokens(
	false,
	true,
	deploymentTypes
	);
	if (!getTokensIsSuccessful) process.exit(1);
	verboseMessage('Importing email provider configuration.');
	const outcome = await configManagerImportEmailProvider();
	if (!outcome) process.exitCode = 1;

	if (!state.getIsIGA()) {
	printMessage(
	'Command not supported for non-IGA cloud tenants',
	'error'
	);
	process.exitCode = 1;
	return;
	}

Uh oh!

Conversation

dallinjsevy commented Apr 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phalestrivir Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

phalestrivir Jul 13, 2026 •

edited

Loading