Conversation
What was broken Preferred roles lived inside the profile rating card, and the entire card was hidden when the stats API did not return a usable rating. Root cause (if identifiable) MemberRatingCard returned an empty fragment whenever getProfileRating(memberStats) was undefined, so both saved roles and the owner edit action were skipped for unrated members. What was changed Decoupled card visibility from rating availability. The rating summary still renders only when a rating exists, while the preferred roles list and owner edit action render independently. Any added/updated tests Updated MemberRatingCard specs to cover saved preferred roles and the owner edit action when rating data is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Preferred roles lived inside the profile rating card, and the entire card was hidden when the stats API did not return a usable rating.
Root cause (if identifiable)
MemberRatingCard returned an empty fragment whenever getProfileRating(memberStats) was undefined, so both saved roles and the owner edit action were skipped for unrated members.
What was changed
Decoupled card visibility from rating availability. The rating summary still renders only when a rating exists, while the preferred roles list and owner edit action render independently.
Any added/updated tests
Updated MemberRatingCard specs to cover saved preferred roles and the owner edit action when rating data is unavailable.
Validation run:
yarn lint passed.
yarn run build passed with existing project warnings.
yarn test:no-watch MemberRatingCard.spec.tsx --runInBand passed.
yarn test:no-watch src/apps/profiles/src --runInBand passed.
yarn test:no-watch --runInBand was run and currently fails in unrelated wallet/work suites, including PaymentAgreementBanner icon rendering, assignment payment helper mocks, engagement assignment detail validation, and existing module-resolution failures outside Profiles.