Conversation
What was broken The previous follow-up still depended on the marker reaching a chart-position threshold before stacking the avatar and score. The regression test only covered a clamped right-edge case, so it did not prove that a 3664-style rating would stack when a wider distribution tail placed the marker before that threshold. Root cause The inline marker layout can still run out of horizontal room for extreme ratings when the distribution range or viewport leaves less usable space than the threshold assumes. What was changed Stack marker labels for extreme ratings in addition to the existing right-edge position threshold, keeping high scores below the avatar before the inline badge can crowd the chart edge. Any added/updated tests Updated the MemberRatingInfoModal regression test with an expanded-tail distribution that places rating 3664 before the 80% threshold and verifies the stacked marker layout still applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The earlier PM-5402 follow-ups stacked the marker only after it crossed a chart-position threshold. QA had already shown the 3664 tourist score staying inline and clipped after the first threshold-based fix, and the regression coverage still only proved a clamped right-edge case.
Root cause
The inline avatar-and-score badge can run out of room for extreme ratings when the distribution tail or compact viewport leaves less horizontal space than a percentage threshold assumes. The existing test did not exercise a high rating before that threshold.
What was changed
Stack marker labels for extreme ratings in addition to the existing right-edge threshold, so very high scores move below the avatar before the inline badge can crowd the chart edge.
Any added/updated tests
Updated the MemberRatingInfoModal regression test with an expanded-tail distribution that places rating 3664 before the 80% threshold and verifies the marker still uses the stacked layout.
Validation
Passed: yarn test:no-watch --runTestsByPath src/apps/profiles/src/member-profile/about-me/MemberRatingCard/MemberRatingInfoModal/MemberRatingInfoModal.spec.tsx
Passed: yarn lint
Passed: yarn run build, with existing CRA build warnings
Not passed: yarn test:no-watch still fails in unrelated work and wallet-admin suites outside this profiles change.