py(deps): Test against libtmux utf-8-encoding branch#1045
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 28 28
Lines 2548 2548
Branches 485 485
=======================================
Hits 2089 2089
Misses 328 328
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tony
force-pushed
the
utf-8-encoding
branch
3 times, most recently
from
52c50c7 to
056ca62
Compare
why: libtmux 0.58.0 fixes subprocess output decoding on non-UTF-8 locales, resolving empty list-accessor results for users whose system locale is not UTF-8.
why: Document the dependency bump for the upcoming release. what: - Add Fixes section noting libtmux ~=0.58.0 floor - Highlight the non-UTF-8 locale decoding fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 28 28
Lines 2548 2548
Branches 485 485
=======================================
Hits 2089 2089
Misses 328 328
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libtmuxdependency to theutf-8-encodingbranch viauv.sourcesto test tmuxp against libtmux's UTF-8 encoding fixContext
libtmux#678 / tmuxp#1044:
tmux_cmdusessubprocess.Popen(text=True)withoutencoding="utf-8", causing FORMAT_SEPARATOR corruption on non-UTF-8 locales. The libtmux fix is at tmux-python/libtmux#679.This PR lets CI validate tmuxp works with the fixed libtmux before it ships.
Test plan
utf-8-encodingbranch