fix(examples): surface navigation errors in ecommerce pricing pagination#159
Open
itsjawreal wants to merge 1 commit into
Open
fix(examples): surface navigation errors in ecommerce pricing pagination#159itsjawreal wants to merge 1 commit into
itsjawreal wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_go_to_the_next_pagehelper in the e-commerce pricing example caught every exception frompage.goto()with a bareexcept Exception: pass, silently swallowing real navigation failures. This change keeps the same control flow but prints the caught error before returningFalse.Why it matters
If
page.goto()fails for a genuine reason (network error, timeout, blocked navigation), the current code silently treats it as "no more pages" and stops pagination with no signal, so an operator sees a truncated result set and cannot tell a real failure from a normal end-of-results.Testing
Static review only: traced the single caller (
extract_pricing_data) and confirmed by inspection that it branches solely on the boolean return value, so adding a diagnosticprinton the existing error path preserves all return values and control flow while making swallowed errors visible. No repo code, tests, or commands were executed.