Skip to content

fix(examples): surface navigation errors in ecommerce pricing pagination#159

Open
itsjawreal wants to merge 1 commit into
tinyfish-io:mainfrom
itsjawreal:itsjawreal-patch-20260718082207
Open

fix(examples): surface navigation errors in ecommerce pricing pagination#159
itsjawreal wants to merge 1 commit into
tinyfish-io:mainfrom
itsjawreal:itsjawreal-patch-20260718082207

Conversation

@itsjawreal

Copy link
Copy Markdown

Summary

The _go_to_the_next_page helper in the e-commerce pricing example caught every exception from page.goto() with a bare except Exception: pass, silently swallowing real navigation failures. This change keeps the same control flow but prints the caught error before returning False.

Why it matters

If page.goto() fails for a genuine reason (network error, timeout, blocked navigation), the current code silently treats it as "no more pages" and stops pagination with no signal, so an operator sees a truncated result set and cannot tell a real failure from a normal end-of-results.

Testing

Static review only: traced the single caller (extract_pricing_data) and confirmed by inspection that it branches solely on the boolean return value, so adding a diagnostic print on the existing error path preserves all return values and control flow while making swallowed errors visible. No repo code, tests, or commands were executed.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0be6ee69-8222-4177-bfac-789f3029ae3a

📥 Commits

Reviewing files that changed from the base of the PR and between 4a8f496 and 86078bc.

📒 Files selected for processing (1)
  • examples/python/collect_ecommerce_pricing_data/main.py

📝 Walkthrough

Walkthrough

Updated _go_to_the_next_page to bind navigation exceptions and print their details, replacing the previous silent exception handling.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: surfacing navigation errors in the ecommerce pricing pagination flow.
Description check ✅ Passed The description matches the code change and explains the fix, impact, and testing approach.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant