Hold the API server cutover until the new API server is ready - #5139
Open
caseydavenport wants to merge 2 commits into
Open
Hold the API server cutover until the new API server is ready#5139caseydavenport wants to merge 2 commits into
caseydavenport wants to merge 2 commits into
Conversation
The v3.projectcalico.org APIService is only repointed once the API server it would point at reports ready replicas.
caseydavenport
added
kind/bug
caseydavenport
commented
Aug 4, 2026
caseydavenport
commented
Aug 4, 2026
An error reading the APIService or the Deployment is not evidence that the cutover is safe.
caseydavenport
marked this pull request as ready for review
August 5, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative fix for EV-6821, opened alongside #5103 so the two can be compared.
On a direct upgrade the operator creates the new API server and repoints the projectcalico.org/v3 APIService at it in the same pass, without checking that the new pod can serve. A leftover default-deny policy denies that pod, and that policy can only be deleted through the API server it denies.
This PR holds the repoint - along with the removal of the old API server's namespace and RBAC - until the new API server reports ready. The old one keeps serving until then, so the installation controller's existing delete of the policy lands and the upgrade continues.
Nothing here knows the name of the deprecated policy, so any other reason the new pod fails to come up also leaves a working API server in place. Already-deadlocked clusters aren't repaired. Not validated on a live cluster yet.
Release Note
For PR author
make gen-files- no API changes.make gen-versions- no version changes.