Add a readiness probe to the calico-webhooks deployment - #5138
Open
caseydavenport wants to merge 1 commit into
Open
Add a readiness probe to the calico-webhooks deployment#5138caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
The pod only joins the webhook Service endpoints once its TLS listener is serving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling the calico-webhooks deployment could briefly reject policy writes. The webhook pod joins the Service endpoints as soon as its container starts, before it is actually serving, and the tiered RBAC webhook fails closed, so a policy write that lands in that window gets rejected.
This adds a readiness probe to the webhook container so the pod only takes traffic once it is serving, matching the probe already present in the Calico helm chart.
CORE-13250