don't keep short HTOA's if their peak level is low#79
Conversation
|
isn't the data stored as integers, in which case you should safely be able to make SILENT=0? |
|
What’s the status of this? |
|
I'm also interested in better HTOA handling. |
|
@thomasvs Could you please state here what’s wrong with this PR? Thanks a lot. :) |
|
hi! any chance that this PR will be accepted? a simple yes or no is enough! 😄 |
|
Something like this will. It needs some interrupted time from me for testing, and I want to make sure it does this only when the silence is absolute - i.e. 100% identical to zero. |
|
Is there anything one could possibly do to help with testing? |
|
+1 to this idea from me |
|
@thomasvs have you taken time to look at and test this PR? |
|
On 09/06/2015 03:04 PM, Matt Hamilton wrote:
T Honeymoon's Great savon - Saving your work to svn |
|
Great. I'll ping you again in a week or so to bother you about it :) |
|
@thomasvs Is there any progress? |
|
@thomasvs pinging you now. It's been 3 weeks :) |
|
ping |
|
@thomasvs I too would like a status update :) |
|
@thomasvs ping |
|
I would be great if this PR was merged :D |
|
Bumping for great justice (+1) |
14 participants
Right now morituri will blindly rip PREGAPs before the first track, even if they're silent. This simple patch lets morituri rip the PREGAP, then checks the rip's peak level as reported by cdparanoia to see whether it's below "SILENT" or not (default to 1e-10). If it's silent, it quietly removes the evidence from the log and cue and carries on with the rip, otherwise the original bevahiour is kept.