ASoC: sdw_utils: return -EPROBE_DEFER if components are not registered yet#5788
Open
bardliao wants to merge 1 commit into
Open
ASoC: sdw_utils: return -EPROBE_DEFER if components are not registered yet#5788bardliao wants to merge 1 commit into
bardliao wants to merge 1 commit into
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the SoundWire ASoC helper logic to avoid building DAI links with “default”/template component names when the real ASoC components (e.g., SDCA function components) have not registered yet, by deferring probe until the components appear.
Changes:
- Change
asoc_sdw_get_codec_name()to return-EPROBE_DEFER(viaERR_PTR) when a specifieddai_info->codec_namecomponent is not registered yet. - Change
asoc_sdw_parse_sdw_endpoints()to return-EPROBE_DEFERwhen required aux components are not registered yet. - Add
IS_ERR()/PTR_ERR()handling forasoc_sdw_get_codec_name()results inasoc_sdw_parse_sdw_endpoints().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1632
to
+1634
| dev_dbg(dev, "%s component %s is not registered yet\n", | ||
| __func__, dai_info->codec_name); | ||
| return ERR_PTR(-EPROBE_DEFER); |
ujfalusi
approved these changes
May 26, 2026
…d yet We set the get the right component name from the registered components and use it in the dai links. It will lead to bind fail if the default component name is used. Return -EPROBE_DEFER to allow the machine driver probe again after the components are registered. Suggested-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We set the get the right component name from the registered components and use it in the dai links. It will lead to bind fail if the default component name is used. Return -EPROBE_DEFER to allow the machine driver probe again after the components are registered.