Skip to content

chore: Mirror the EventSourcingDB Biome configuration and resolve lint violations #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goloroden merged 3 commits into from
Jun 27, 2026
Merged

chore: Mirror the EventSourcingDB Biome configuration and resolve lint violations #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6985849
chore: bump @biomejs/biome from 2.4.16 to 2.5.0
dependabot[bot] Jun 26, 2026
159c06b
chore: Mirror the EventSourcingDB Biome configuration and resolve lin…
goloroden Jun 27, 2026
63b6dfc
chore: Align the TypeScript module setting with the bundled ESM output.
goloroden Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 34 additions & 12 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,32 @@
}
},
"linter": {
"domains": {
"test": "all"
},
"enabled": true,
"rules": {
"complexity": {
"noExcessiveCognitiveComplexity": "off"
},
"preset": "all",
"nursery": "on",
"correctness": {
"noPrivateImports": "off"
"noNodejsModules": "off",
"useImportExtensions": {
"level": "on",
"options": {
"forceJsExtensions": true
}
},
"useQwikValidLexicalScope": "off",
"useHookAtTopLevel": "off"
},
"performance": "on",
"security": "on",
"suspicious": "on",
"style": {
"useFilenamingConvention": "off"
"useFilenamingConvention": {
"level": "on",
"options": {
"filenameCases": ["camelCase", "PascalCase"]
}
},
"noContinue": "off"
},
"security": {
"noSecrets": "off"
}
}
},
Expand All @@ -58,5 +68,17 @@
"organizeImports": "on"
}
}
}
},
"overrides": [
{
"includes": ["**/*.test.ts"],
"linter": {
"rules": {
"style": {
"noMagicNumbers": "off"
}
}
}
}
]
}
84 changes: 48 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"testcontainers": "12.0.3"
},
"devDependencies": {
"@biomejs/biome": "2.4.16",
"@biomejs/biome": "2.5.0",
"@types/node": "25.9.3",
"get-port": "7.2.0",
"tsdown": "0.22.3",
Expand Down
34 changes: 17 additions & 17 deletions src/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ interface ResponseBodyReadEventType {
}

class Client {
#url: URL;
#apiToken: string;
readonly #url: URL;
readonly #apiToken: string;

#getUrl(path: string): string {
return new URL(path, this.#url).toString();
Expand Down Expand Up @@ -160,17 +160,17 @@ class Client {
const url = this.#getUrl('/api/v1/read-events');
const apiToken = this.#apiToken;

return (async function* () {
return (async function* (): AsyncGenerator<Event, void, void> {
const internalAbortController = new AbortController();
const combinedSignal = signal ?? internalAbortController.signal;
const shouldAbortInternally = !signal;

let removeAbortListener: (() => void) | undefined;

if (signal && !signal.aborted) {
const onAbort = () => internalAbortController.abort();
const onAbort = (): void => internalAbortController.abort();
signal.addEventListener('abort', onAbort, { once: true });
removeAbortListener = () => signal.removeEventListener('abort', onAbort);
removeAbortListener = (): void => signal.removeEventListener('abort', onAbort);
}

try {
Expand Down Expand Up @@ -236,17 +236,17 @@ class Client {
const url = this.#getUrl('/api/v1/run-eventql-query');
const apiToken = this.#apiToken;

return (async function* () {
return (async function* (): AsyncGenerator<unknown, void, void> {
const internalAbortController = new AbortController();
const combinedSignal = signal ?? internalAbortController.signal;
const shouldAbortInternally = !signal;

let removeAbortListener: (() => void) | undefined;

if (signal && !signal.aborted) {
const onAbort = () => internalAbortController.abort();
const onAbort = (): void => internalAbortController.abort();
signal.addEventListener('abort', onAbort, { once: true });
removeAbortListener = () => signal.removeEventListener('abort', onAbort);
removeAbortListener = (): void => signal.removeEventListener('abort', onAbort);
}

try {
Expand Down Expand Up @@ -316,17 +316,17 @@ class Client {
const url = this.#getUrl('/api/v1/observe-events');
const apiToken = this.#apiToken;

return (async function* () {
return (async function* (): AsyncGenerator<Event, void, void> {
const internalAbortController = new AbortController();
const combinedSignal = signal ?? internalAbortController.signal;
const shouldAbortInternally = !signal;

let removeAbortListener: (() => void) | undefined;

if (signal && !signal.aborted) {
const onAbort = () => internalAbortController.abort();
const onAbort = (): void => internalAbortController.abort();
signal.addEventListener('abort', onAbort, { once: true });
removeAbortListener = () => signal.removeEventListener('abort', onAbort);
removeAbortListener = (): void => signal.removeEventListener('abort', onAbort);
}

try {
Expand Down Expand Up @@ -426,17 +426,17 @@ class Client {
const url = this.#getUrl('/api/v1/read-subjects');
const apiToken = this.#apiToken;

return (async function* () {
return (async function* (): AsyncGenerator<string, void, void> {
const internalAbortController = new AbortController();
const combinedSignal = signal ?? internalAbortController.signal;
const shouldAbortInternally = !signal;

let removeAbortListener: (() => void) | undefined;

if (signal && !signal.aborted) {
const onAbort = () => internalAbortController.abort();
const onAbort = (): void => internalAbortController.abort();
signal.addEventListener('abort', onAbort, { once: true });
removeAbortListener = () => signal.removeEventListener('abort', onAbort);
removeAbortListener = (): void => signal.removeEventListener('abort', onAbort);
}

try {
Expand Down Expand Up @@ -535,17 +535,17 @@ class Client {
const url = this.#getUrl('/api/v1/read-event-types');
const apiToken = this.#apiToken;

return (async function* () {
return (async function* (): AsyncGenerator<EventType, void, void> {
const internalAbortController = new AbortController();
const combinedSignal = signal ?? internalAbortController.signal;
const shouldAbortInternally = !signal;

let removeAbortListener: (() => void) | undefined;

if (signal && !signal.aborted) {
const onAbort = () => internalAbortController.abort();
const onAbort = (): void => internalAbortController.abort();
signal.addEventListener('abort', onAbort, { once: true });
removeAbortListener = () => signal.removeEventListener('abort', onAbort);
removeAbortListener = (): void => signal.removeEventListener('abort', onAbort);
}

try {
Expand Down
6 changes: 3 additions & 3 deletions src/Container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ import type { Content, StartedTestContainer } from 'testcontainers';
import { GenericContainer, Wait } from 'testcontainers';
import { Client } from './Client.js';

type ContentToCopy = {
interface ContentToCopy {
content: Content;
target: string;
mode?: number;
};
}

class Container {
#imageName = 'thenativeweb/eventsourcingdb';
readonly #imageName = 'thenativeweb/eventsourcingdb';
#imageTag = 'latest';
#internalPort = 3000;
#apiToken = 'secret';
Expand Down
5 changes: 2 additions & 3 deletions src/convertCloudEventToEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import type { CloudEvent } from './CloudEvent.js';
import { Event } from './Event.js';

const convertCloudEventToEvent = (cloudEvent: CloudEvent): Event => {
return new Event({
const convertCloudEventToEvent = (cloudEvent: CloudEvent): Event =>
new Event({
specversion: cloudEvent.specversion,
id: cloudEvent.id,
time: new Date(cloudEvent.time),
Expand All @@ -18,6 +18,5 @@ const convertCloudEventToEvent = (cloudEvent: CloudEvent): Event => {
tracestate: cloudEvent.tracestate,
signature: cloudEvent.signature,
});
};

export { convertCloudEventToEvent };
Loading
Loading