🎨 Palette: Improve Search input accessibility and keyboard navigation#262
🎨 Palette: Improve Search input accessibility and keyboard navigation#262thebearwithabite wants to merge 1 commit into
Conversation
Co-authored-by: thebearwithabite <216692431+thebearwithabite@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added
role="search"to the search form wrapper,aria-hidden="true"to the decorative search icon, an explicitaria-labelto the search input, andfocus-visiblestyles to the search submit button.🎯 Why:
The search field acts as the primary interaction point on the Search page. Screen readers require explicit context via
role="search"andaria-labels on inputs that lack visual<label>tags. The submit button requires explicit keyboard focus styles for visibility.📸 Before/After:
Before:
<form ...>,<input placeholder="...">,<button className="...">After:
<form ... role="search">,<input ... aria-label="Search for files">,<button className="... focus-visible:ring-2 ...">♿ Accessibility:
role="search".aria-labelon the primary input.aria-hidden="true".focus-visiblestyles on the button.PR created automatically by Jules for task 12999041570355771716 started by @thebearwithabite